hundreds-father-404
05/16/2019, 5:49 AMFileContent
. The thing is, I have no idea what is causing that to get persisted. I don’t see it anywhere in the outputted graph or in our code related to Pytest.average-vr-56795
05/16/2019, 12:47 PMhundreds-father-404
05/16/2019, 3:03 PMFileContent
?
Notably, we do serialize the BUILD
file for ./pants list
, just it’s always never more than one file.
Looking at the rule graph, I’m wondering if Validate
is happening?FileContent
for sources which is great.
The remaining issue is that we materialize each BUILD
file involved in the sourcesaverage-vr-56795
05/16/2019, 4:19 PMparse_address_family
hundreds-father-404
05/16/2019, 4:20 PMYeah, that’ll be inIs the only fix for this to move that logic to Rust? Could we possibly do that? Sending materialized files seems very costlyparse_address_family
and for the bytes to only be handed to the rule outside the graph somehow…Have Python use
with open()
to grab the bytes itself?average-vr-56795
05/16/2019, 4:21 PMwitty-crayon-22786
05/16/2019, 4:22 PMhundreds-father-404
05/16/2019, 4:30 PM./pants list
also should not be keeping the BUILD
file contents in the handles at the end of its run, right? If so, I’ll focus on solving that because it’s a simpler rule and would also by extension fix this O(b)
behavior for test runner (where b
is number of BUILD files)witty-crayon-22786
05/16/2019, 4:31 PMhundreds-father-404
05/16/2019, 4:33 PMO(t + b)
is very different than O(t + n)
- keeping all the BUILD files in memory vs. the entire repo in memorywitty-crayon-22786
05/16/2019, 4:34 PM