https://pantsbuild.org/ logo
a

average-vr-56795

05/22/2019, 2:35 PM
@witty-crayon-22786 I would like to change the logging in scheduler.rsā€™s
execute_helper
function so that for `ExecuteProcessReequest`s it logs
Root ExecuteProcessRequest(description)
rather than `Root ExecuteProcessRequest(entire python repr)`ā€¦ Is there a handy way of doing that, or do I need to futz with lots of things?
šŸ‘ 1
w

witty-crayon-22786

05/23/2019, 5:15 PM
@average-vr-56795: mm. that would be... maybe the wrong place to add a special case
in particular, that's how "Nodes are Display'd"
i think that if what you are going for is "executing processes generate useful output at
debug
level", then you should do that closer to the invoke
and we could move the "some root finished" logging to trace
a

average-vr-56795

05/23/2019, 9:56 PM
I was thinking of making the str implementation of EPR be much less verbose, and making repr be the current verbosity...
w

witty-crayon-22786

05/23/2019, 11:56 PM
My feeling is that we don't want to get in the habit of relying on
str
to make rendering nicer
(for example: we should probably have a specific implementation for
--v2-ui
that does something human readable for the "path through the heavy hitters")
a

average-vr-56795

05/28/2019, 9:03 AM
Yeah, explicit interfaces sound good šŸ™‚