https://pantsbuild.org/ logo
#development
Title
# development
e

enough-analyst-54434

06/25/2019, 7:15 PM
A sanity check from engine / pantsd hackers. Afaict its currently the case, mod bugs, that any change to the BuildConfiguration should cause a daemon restart. The sanity check comes in because the mapping is not obvious / direct since the invalidation key is the bootstrap options fingerprint and not the fingerprint of the BuildConfiguration object itself. Pretty sure these should always jive though mod bugs.
w

witty-crayon-22786

06/25/2019, 7:35 PM
sortof... there are bootstrap options marked
daemon=False
that do not trigger a restart. the rest do
e

enough-analyst-54434

06/25/2019, 7:37 PM
Ok, thanks. That example seems to further confirm.
w

witty-crayon-22786

06/25/2019, 7:38 PM
there are other holes in this though: https://github.com/pantsbuild/pants/issues/7022 ... subsystems in general do not cause restarts
and so BUILD logic depending on them, or on undeclared files is an issue
e

enough-analyst-54434

06/25/2019, 7:39 PM
Yeah, the central worry driving this is limited in scope to BuildConfiguration changes, of which these examples are not.
w

witty-crayon-22786

06/25/2019, 7:39 PM
that is a very design heavy task, but the last paragraph on the description suggests a path forward if someone is looking to improve the situation
sounds good