<@U06A03HV1> here is a minimal diff demonstrating ...
# developmente
early-needle-54791
07/10/2019, 5:10 PM@witty-crayon-22786 here is a minimal diff demonstrating the problem. the errors look like
Copy code
error[E0308]: mismatched types
--> process_execution/src/remote.rs:1713:37
|
1713 | super::make_execute_request(&execute_request, &None, &None, BTreeMap::new())
| ^^^^^^^^^^^^^^^^ expected struct `ExecuteProcessRequest`, found struct `process_execution::ExecuteProcessRequest`
|
= note: expected type `&ExecuteProcessRequest`
found type `&process_execution::ExecuteProcessRequest`early-needle-54791
07/10/2019, 5:11 PMit seems like the struct gets a new identity when it is used for a different crate (though this makes no sense to me)
w
witty-crayon-22786
07/10/2019, 5:21 PM-
witty-crayon-22786
07/10/2019, 5:21 PM@average-vr-56795: ^ puzzler
witty-crayon-22786
07/10/2019, 5:24 PMthe stackoverflow answer isn't... super useful
witty-crayon-22786
07/10/2019, 5:26 PMoooh, nevermind. that's not related
a
average-vr-56795
07/10/2019, 5:35 PMI applied the diff and didn’t repro
average-vr-56795
07/10/2019, 5:36 PMCan you push a branch?
average-vr-56795
07/10/2019, 5:36 PMOh wait!
average-vr-56795
07/10/2019, 5:36 PMI do repro!
average-vr-56795
07/10/2019, 5:39 PMMy guess is it’s because there’s on some level a circular dependency? I need to run, but I’ll have a play tomorrow… In the mean time, avoiding the circular dep will probably get you unblocked
w
witty-crayon-22786
07/10/2019, 5:45 PMthe test crate of the crate shouldn't have the circular dep? but yea, possibly. maybe it's not actually treated as a separate crate.
witty-crayon-22786
07/10/2019, 5:45 PMthanks... not a blocker for now.
witty-crayon-22786
07/10/2019, 10:42 PM@early-needle-54791: via Daniel: https://github.com/rust-lang/cargo/issues/6765
witty-crayon-22786
07/10/2019, 10:43 PM(haven't read it yet: still fine with duping the method with a TODO)
e
early-needle-54791
07/10/2019, 10:45 PMInteresting. Thanks. I have just duplicated the function for now.
early-needle-54791
07/10/2019, 10:45 PManother option would be a local testutil module in the process_execution crate
a
average-vr-56795
07/11/2019, 9:27 AMIs the problem that you’re trying to re-use the function from a different crate, or that you’re trying to re-use the function from a different module?