happy-kitchen-89482
08/15/2019, 12:58 AMwitty-crayon-22786
08/15/2019, 4:30 PMhappy-kitchen-89482
08/15/2019, 5:30 PMresources
target, so it doesn't have a custom adaptor, just the one generated in _make_target_adaptor
happy-kitchen-89482
08/15/2019, 5:30 PMwitty-crayon-22786
08/15/2019, 5:30 PMhappy-kitchen-89482
08/15/2019, 5:31 PMrglobs
happy-kitchen-89482
08/15/2019, 5:31 PMwitty-crayon-22786
08/15/2019, 5:32 PMhappy-kitchen-89482
08/15/2019, 5:33 PMwitty-crayon-22786
08/15/2019, 5:34 PMtest
rules definitely consume resources, so perhaps the callsite is relevant?happy-kitchen-89482
08/15/2019, 5:35 PMwitty-crayon-22786
08/15/2019, 5:36 PMwitty-crayon-22786
08/15/2019, 5:37 PMhappy-kitchen-89482
08/15/2019, 5:40 PMget_sources()
(which does its own check for the sources attr) is the right thing to use, instead of checking if not hasattr(maybe_source_target, 'sources'):
ourselveshappy-kitchen-89482
08/15/2019, 5:40 PMhappy-kitchen-89482
08/15/2019, 5:41 PMwitty-crayon-22786
08/15/2019, 5:41 PMwitty-crayon-22786
08/15/2019, 5:42 PMmaybe_source_target.sources.snapshot
is a Snapshothappy-kitchen-89482
08/15/2019, 5:50 PMhappy-kitchen-89482
08/15/2019, 5:50 PMhappy-kitchen-89482
08/15/2019, 6:04 PMmaybe_source_target.sources
?witty-crayon-22786
08/15/2019, 6:05 PMwitty-crayon-22786
08/15/2019, 6:05 PMhappy-kitchen-89482
08/15/2019, 6:05 PMhappy-kitchen-89482
08/15/2019, 6:06 PMsnapshot
memberhappy-kitchen-89482
08/15/2019, 6:06 PMget_sources()
seems to assume that it's one of the types that BaseGlobs.from_sources_field
can handlehappy-kitchen-89482
08/15/2019, 6:06 PMwitty-crayon-22786
08/15/2019, 6:09 PMhappy-kitchen-89482
08/15/2019, 6:14 PMpants.source.wrapped_globs.EagerFilesetWithSpec
in all cases (!)witty-crayon-22786
08/15/2019, 6:16 PMhappy-kitchen-89482
08/15/2019, 6:16 PMhappy-kitchen-89482
08/15/2019, 6:19 PMwitty-crayon-22786
08/15/2019, 6:20 PMhappy-kitchen-89482
08/15/2019, 6:21 PMwitty-crayon-22786
08/15/2019, 6:22 PMwitty-crayon-22786
08/15/2019, 6:48 PMhappy-kitchen-89482
08/15/2019, 6:54 PMaverage-vr-56795
08/27/2019, 1:10 PM