had some fun implementing python run in v2: <https...
# developmenta
aloof-angle-91616
09/04/2019, 2:29 AMhad some fun implementing python run in v2: https://github.com/pantsbuild/pants/pull/8236
🎉 2
h
hundreds-father-404
09/04/2019, 1:52 PMYay! It looks like this implementation can be used to implement python binary? If I’m reading correctly, python run == python binary + actually running that PEX
We’ll probably want to extract out a lot of the duplicated logic with python_test_runner.py, such as the source root stripping
a
aloof-angle-91616
09/04/2019, 4:46 PMthat's correct, this was hacked together in a few hours to show off to a twitter engineer
aloof-angle-91616
09/04/2019, 4:46 PMremoving the duplicated logic should also reduce the diff size considerably
aloof-angle-91616
09/04/2019, 4:47 PMright now i'm focusing on python run because python binary requires creating a file in dist/ and i don't want to figure that out just yet
👍 1
aloof-angle-91616
09/04/2019, 4:47 PMbut yes, your description is correct