<@U06A03HV1> Why does `scheduler_create` returns a...
# developmenta
average-vr-56795
09/10/2019, 4:34 PM@witty-crayon-22786 Why does
scheduler_createHandleaverage-vr-56795
09/10/2019, 5:08 PMContext: https://github.com/pantsbuild/pants/pull/8275 has a massive TODO because of that question
w
witty-crayon-22786
09/10/2019, 5:18 PMhm... just historical reasons, i think?
witty-crayon-22786
09/10/2019, 5:18 PMit was probably the absolute first method that existed
witty-crayon-22786
09/10/2019, 5:18 PMoh. wait. no
witty-crayon-22786
09/10/2019, 5:18 PMit returns a raw pointer because it is not a python object
witty-crayon-22786
09/10/2019, 5:19 PMto return a Handle you'd have to "convert" it into a python object
a
average-vr-56795
09/10/2019, 5:19 PMOk, so for that PR I should probably make a one off
NonPyResultPyResultw
witty-crayon-22786
09/10/2019, 5:19 PMor use some other C calling convention... yea, i think so.
a
average-vr-56795
09/10/2019, 5:20 PMCool, will do 🙂 Thanks!
w
witty-crayon-22786
09/10/2019, 5:20 PMalthough, i don't know if
NonPyResulta
average-vr-56795
09/10/2019, 5:21 PMI’m imagining:
Copy code
struct NonPyResult {
is_throw: bool,
throw: Option<Handle>,
pointer: Option<*const raw::c_void>,
}w
witty-crayon-22786
09/10/2019, 5:21 PM...could maybe extract a trait, if it has useful things? similar to: https://github.com/pantsbuild/pants/blob/714fdb70aff66eb835c32a1fa33e5485616671df/src/rust/engine/src/externs.rs#L529-L558
witty-crayon-22786
09/10/2019, 5:22 PMRawResultwitty-crayon-22786
09/10/2019, 5:22 PMyea
a
average-vr-56795
09/10/2019, 5:36 PMPushed - please review at your convenience!
w
witty-crayon-22786
09/10/2019, 5:44 PM@average-vr-56795: commented
witty-crayon-22786
09/10/2019, 5:44 PM(two comments)