hundreds-father-404
09/13/2019, 4:17 AMException: WithDeps(Inner(InnerEntry { params: {PythonTestsAdaptor, OptionsBootstrapper}, rule: Task(Task { product: TestResult, clause: [Select { product: PythonTestsAdaptor }, Select { product: PyTest }, Select { product: PythonSetup }, Select { product: SubprocessEncodingEnvironment }], gets: [Get { product: TransitiveHydratedTargets, subject: BuildFileAddresses }, Get { product: RequirementsPex, subject: RequirementsPexRequest }, Get { product: SourceRootStrippedSources, subject: TargetAdaptor }, Get { product: Digest, subject: DirectoriesToMerge }, Get { product: InjectedInitDigest, subject: Digest }, Get { product: FallibleExecuteProcessResult, subject: ExecuteProcessRequest }], func: run_python_test(), cacheable: true }) })) did not declare a dependency on JustGet(Get { product: SourceRootStrippedSources, subject: PythonTestsAdaptor })
I’m not sure how to interpret this. If someone could take a look at https://github.com/pantsbuild/pants/pull/8284/files please, would be much appreciatedwitty-crayon-22786
09/13/2019, 4:23 AMGet(SourceRootStrippedSources, TargetAdaptor, target_adaptor)
target_adaptor
is not exactly a TargetAdaptor: it's a subclass: PythonTestsAdaptor
in this case.hundreds-father-404
09/13/2019, 4:26 AMyield Get(SourceRootStrippedSources, PythonTestsAdaptor, test_target)
? Inheritance will wok with that?witty-crayon-22786
09/13/2019, 4:26 AMGet
constructor@union
)hundreds-father-404
09/13/2019, 4:27 AMstrip_source_root
to stay general in accepting TargetAdaptor
witty-crayon-22786
09/13/2019, 4:29 AM@union
declared for the relevant legal types ("things that might have python sources") or would need to lean further in on https://github.com/pantsbuild/pants/issues/4535aloof-angle-91616
09/14/2019, 5:25 PM