Extracted out rule strip source roots failing due ...
# developmenth
hundreds-father-404
09/13/2019, 4:17 AMExtracted out rule strip source roots failing due to:
Copy code
Exception: WithDeps(Inner(InnerEntry { params: {PythonTestsAdaptor, OptionsBootstrapper}, rule: Task(Task { product: TestResult, clause: [Select { product: PythonTestsAdaptor }, Select { product: PyTest }, Select { product: PythonSetup }, Select { product: SubprocessEncodingEnvironment }], gets: [Get { product: TransitiveHydratedTargets, subject: BuildFileAddresses }, Get { product: RequirementsPex, subject: RequirementsPexRequest }, Get { product: SourceRootStrippedSources, subject: TargetAdaptor }, Get { product: Digest, subject: DirectoriesToMerge }, Get { product: InjectedInitDigest, subject: Digest }, Get { product: FallibleExecuteProcessResult, subject: ExecuteProcessRequest }], func: run_python_test(), cacheable: true }) })) did not declare a dependency on JustGet(Get { product: SourceRootStrippedSources, subject: PythonTestsAdaptor })w
witty-crayon-22786
09/13/2019, 4:23 AM Copy code
Get(SourceRootStrippedSources, TargetAdaptor, target_adaptor)witty-crayon-22786
09/13/2019, 4:23 AMinheritance is not used here
witty-crayon-22786
09/13/2019, 4:25 AMand
target_adaptorPythonTestsAdaptorh
hundreds-father-404
09/13/2019, 4:26 AMHm so it should be
yield Get(SourceRootStrippedSources, PythonTestsAdaptor, test_target)w
witty-crayon-22786
09/13/2019, 4:26 AMno: inheritance is not used anywhere in the engine
👍 1
witty-crayon-22786
09/13/2019, 4:26 AMso the second and third types need to exactly match.
witty-crayon-22786
09/13/2019, 4:27 AMwe could fail a lot faster there, with a better error message
witty-crayon-22786
09/13/2019, 4:27 AM...in the
Getwitty-crayon-22786
09/13/2019, 4:27 AM(the only exception is for
@unionh
hundreds-father-404
09/13/2019, 4:27 AMGot it. Is there any way to make this work with inheritance? We need the rule
strip_source_rootTargetAdaptorw
witty-crayon-22786
09/13/2019, 4:29 AMnot really... would either need an
@union🤔 1
a
aloof-angle-91616
09/14/2019, 5:25 PMhack week hack week
👌 1
aloof-angle-91616
09/14/2019, 5:25 PMi was absolutely thinking that we could attempt to infer `@union`s from subtypes, but only as syntax sugar