Extracted out rule strip source roots failing due to ``` Exc

Question

Extracted out rule strip source roots failing due to ``` Exception WithDeps Inner InnerEntry params PythonTestsAdaptor OptionsBootstrapper rule Task Task product TestResult clause Select product PythonTestsAdaptor Select product PyTest Select product PythonSetup Select product SubprocessEncodingEnvironment gets Get product TransitiveHydratedTargets subject BuildFileAddresses Get product RequirementsPex subject RequirementsPexRequest Get product SourceRootStrippedSources subject TargetAdaptor Get product Digest subject DirectoriesToMerge Get product InjectedInitDigest subject Digest Get product FallibleExecuteProcessResult subject ExecuteProcessRequest func run python test cacheable true did not declare a dependency on JustGet Get product SourceRootStrippedSources subject PythonTestsAdaptor ``` I m not sure how to interpret this If someone could take a look at <https github com pantsbuild pants pull 8284 files> please would be much appreciated

witty-crayon-22786 · Answer

```Get SourceRootStrippedSources TargetAdaptor target adaptor ```

witty-crayon-22786 · Answer

inheritance is not used here

witty-crayon-22786 · Answer

and `target adaptor` is not exactly a TargetAdaptor it s a subclass `PythonTestsAdaptor` in this case

hundreds-father-404 · Answer

Hm so it should be `yield Get SourceRootStrippedSources PythonTestsAdaptor test target ` Inheritance will wok with that

witty-crayon-22786 · Answer

no inheritance is not used anywhere in the engine

witty-crayon-22786 · Answer

so the second and third types need to exactly match

witty-crayon-22786 · Answer

we could fail a lot faster there with a better error message

witty-crayon-22786 · Answer

in the `Get` constructor

witty-crayon-22786 · Answer

the only exception is for ` union`

hundreds-father-404 · Answer

Got it Is there any way to make this work with inheritance We need the rule `strip source root` to stay general in accepting `TargetAdaptor`

witty-crayon-22786 · Answer

not really would either need an ` union` declared for the relevant legal types things that might have python sources or would need to lean further in on <https github com pantsbuild pants issues 4535>

aloof-angle-91616 · Answer

hack week hack week

aloof-angle-91616 · Answer

i was absolutely thinking that we could attempt to infer ` union`s from subtypes but only as syntax sugar