calling `python_binary_adaptor.sources` gets me a ...
# developmenth
hundreds-breakfast-49010
09/30/2019, 9:53 PMcalling
python_binary_adaptor.sourcesEagerFilesetWithSpeca
aloof-angle-91616
09/30/2019, 10:08 PMis there a branch i can look at here? weren't we able to just get the sources snapshot from the target earlier?
h
hundreds-breakfast-49010
09/30/2019, 10:09 PMhundreds-breakfast-49010
09/30/2019, 10:10 PMI don't want the snapshot though, I want the entire
SourcesFieldhundreds-breakfast-49010
09/30/2019, 10:12 PMbasically I'm trying to duplicate this method: https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/python/targets/python_binary.py#L144-L152 on
PYthonBinaryAdaptorSourcesFielda
average-vr-56795
09/30/2019, 10:22 PMI suspect https://github.com/pantsbuild/pants/issues/6659 will be an issue for you
average-vr-56795
09/30/2019, 10:24 PMYou should be able to (ugly though it may be)
next(filter(lambda f: isinstance(f, SourcesField), target_adaptor.field_adaptors))average-vr-56795
09/30/2019, 10:24 PMFeel free to redesign as much of that class as you fancy to make it not a) ugly and b) broken 😉
h
hundreds-breakfast-49010
09/30/2019, 10:25 PMhm, ok
hundreds-breakfast-49010
09/30/2019, 10:25 PMmaybe I've gone down a bit too deep a rabbit hole here
a
average-vr-56795
09/30/2019, 10:25 PM😄
h
hundreds-breakfast-49010
09/30/2019, 10:26 PMbasically, what I care about doing is getting the logic in
PythonBinary.entry_pointPythonBinaryAdaptorhundreds-breakfast-49010
09/30/2019, 10:26 PMa
average-vr-56795
09/30/2019, 10:27 PMI believe all you need to do that is to check “Hey, the EagerFilesetWithSpec, does its snapshot contain exactly one file? If so, that’s the default entrypoint”
average-vr-56795
09/30/2019, 10:27 PMModulo source_root stripping, which IIRC @hundreds-father-404 implemented somewhere
average-vr-56795
09/30/2019, 10:27 PMSo the logic would be roughly:
average-vr-56795
09/30/2019, 10:28 PMIs there an entry_point field? Great, use it
Is the source snapshot exactly one file? Great, strip the source root and use it
Else no entry point for you
h
hundreds-breakfast-49010
09/30/2019, 10:28 PMyeah I'm using code substantially baed on his
hundreds-breakfast-49010
09/30/2019, 10:28 PMok
a
average-vr-56795
09/30/2019, 10:29 PM(With an upsetting amount of
getattrhasattr