red-balloon-89377
10/09/2019, 11:17 AMCommandRunner hierarchy for nailgunnable local EPRs, and I’m not really sure what to pick, so probing here in case someone has strong opinions:
1. I have a NailgunCommandRunner, that holds an instance of local::CommandRunner, and short-circuits to it when handling a non-nailgunnable EPR.
2. Put the nailgunning logic in local::CommandRunner, and just handle all of it there.
3. Have local::CommandRunner hold an instance of a NailgunCommandRunner, but that creates the problem where the NailgunCommandRunner wants access to the local::CommandRunner::run method.
I weakly lean towards 1, because it means that the nailgunning logic is contained within a struct, but that also exposes nailgun in places where we might not want to care about it.average-vr-56795
10/09/2019, 11:18 AMred-balloon-89377
10/09/2019, 11:18 AM