Is there previous art of requiring a jar from a V2...
# developmentr
red-balloon-89377
10/10/2019, 12:38 PMIs there previous art of requiring a jar from a V2 rule? THinking of creating something like
@rule(NailgunServerJar, [JarSpec])product_requestzinc_compile.pyred-balloon-89377
10/10/2019, 12:40 PMOhh, I can take inspiration from the C++ pipeline by @aloof-angle-91616! Thanks for defining
BinaryToolScriptred-balloon-89377
10/10/2019, 12:45 PMOh, but that may get deprecated when we implement v2 resolving đ I think for the Nailgun server jar, it would be better to just snapshot the jar we request in zinc_compile, and use the
Scripta
aloof-angle-91616
10/10/2019, 3:02 PMBinaryToolScriptScriptaloof-angle-91616
10/10/2019, 3:03 PMif you look at
src/python/pants/backend/jvm/tasks/coursier/coursier_subsystem.pyaloof-angle-91616
10/10/2019, 3:03 PMhaving
UrlToFetch -> Snapshotr
red-balloon-89377
10/10/2019, 3:04 PMI totally agree, i just meant for the case of âI just want a jar from maven with this coordinatesâ, which should be handled by jvm resolution when we have that in V2.andBinaryToolshouldnât be getting deprecated!Script
a
aloof-angle-91616
10/10/2019, 3:05 PMyes! but i wouldn't block on that being available although it shouldn't necessarily be hard to do if we're planning to soon
r
red-balloon-89377
10/10/2019, 3:06 PMI fortunately solved that problem through just snapshotting the jar in the python side: https://github.com/pantsbuild/pants/pull/8371/commits/ec206523a4972cc66c02b493955358c25d8a05c9
a
aloof-angle-91616
10/10/2019, 3:06 PMok wonderful!
aloof-angle-91616
10/10/2019, 3:06 PMoh yes ok this is correct
aloof-angle-91616
10/10/2019, 3:06 PMthanks!
4 Views