enough-analyst-54434
10/14/2019, 2:04 PMaverage-vr-56795
10/14/2019, 2:04 PMgrpc/grpc
, feel free to delete 🙂enough-analyst-54434
10/14/2019, 2:05 PMaverage-vr-56795
10/14/2019, 2:05 PMenough-analyst-54434
10/14/2019, 2:05 PMaverage-vr-56795
10/14/2019, 2:06 PMenough-analyst-54434
10/14/2019, 2:07 PMaverage-vr-56795
10/14/2019, 2:08 PMInto
impl for each proto type so I could just sprinkle around .into()
calls in tests, and then casually do actual re-writing separately. I got bored because nested protos made it more hassle than it was worth.
4. The reason we reverted it was we saw the channel to the execution server occasionally drop and then further attempts to use it unconditionally fail. I don’t know whether grpc-rs has some internal retries or something, or tower needs keepalives, or just to retry connections or whatever. I couldn’t repro locally or in tests, only in production 😞witty-crayon-22786
10/14/2019, 3:59 PMaverage-vr-56795
10/14/2019, 4:06 PMearly-needle-54791
10/14/2019, 9:22 PMerror: failed to load source for a dependency on `grpcio`
Caused by:
Unable to update <https://github.com/pantsbuild/grpc-rs.git?rev=9dd357da5a2f231ce254d8abdd46068198637beb#9dd357da>
Caused by:
failed to update submodule `grpc-sys/grpc`
Caused by:
failed to fetch submodule `grpc-sys/grpc` from <https://github.com/pantsbuild/grpc.git>
Caused by:
failed to authenticate when downloading repository
attempted to find username/password via git's `credential.helper` support, but failed
Caused by:
failed to acquire username/password from local configuration
Error during execution of `cargo metadata`: error: failed to load source for a dependency on `grpcio`
Caused by:
Unable to update <https://github.com/pantsbuild/grpc-rs.git?rev=9dd357da5a2f231ce254d8abdd46068198637beb#9dd357da>
Caused by:
failed to update submodule `grpc-sys/grpc`
Caused by:
failed to fetch submodule `grpc-sys/grpc` from <https://github.com/pantsbuild/grpc.git>
Caused by:
failed to authenticate when downloading repository
attempted to find username/password via git's `credential.helper` support, but failed
Caused by:
failed to acquire username/password from local configuration
enough-analyst-54434
10/14/2019, 9:24 PMCaused by:
failed to fetch submodule `grpc-sys/grpc` from <https://github.com/pantsbuild/grpc.git>
early-needle-54791
10/14/2019, 9:26 PMenough-analyst-54434
10/14/2019, 9:31 PMearly-needle-54791
10/14/2019, 9:32 PMenough-analyst-54434
10/14/2019, 9:34 PMwitty-crayon-22786
10/14/2019, 9:40 PMenough-analyst-54434
10/14/2019, 9:41 PMwitty-crayon-22786
10/14/2019, 9:45 PM~/.cache/pants/rust/cargo/git/checkouts/
$ ls -1 ~/.cache/pants/rust/cargo/git/checkouts/
futures-timer-657d237f95a485bf
grpc-rs-b50c79747a664460
h2-5627e19d2c95dbee
lmdb-rs-369bfd26153a2575
rust-protobuf-8e8a2cd87e934b3d
string-8a0320b15d60e666
termion-994101b84ecd1aab
tokio-connect-0fb9e2e939118ab0
tokio-connect-35101edd25624c88
tower-20b7cbb22dd35c99
tower-b098c32cf5a1bcca
tower-grpc-6de8565ab246a0cf
tower-h2-7c0484bd51f493bd
tower-h2-aaf68b3c8982de4c
tower-http-243b30f79c7df9d4
tower-http-8b33967e083bb0de
enough-analyst-54434
10/14/2019, 9:48 PMwitty-crayon-22786
10/14/2019, 9:48 PM~/.cache/pants/rust/cargo/git/checkouts/grpc-rs-b50c79747a664460/4dfafe9
enough-analyst-54434
10/14/2019, 9:49 PMwitty-crayon-22786
10/14/2019, 9:52 PMearly-needle-54791
10/14/2019, 9:52 PMenough-analyst-54434
10/14/2019, 9:52 PMearly-needle-54791
10/14/2019, 9:53 PMwitty-crayon-22786
10/14/2019, 9:54 PMenough-analyst-54434
10/14/2019, 9:55 PMearly-needle-54791
10/14/2019, 9:58 PMwitty-crayon-22786
10/14/2019, 9:59 PMenough-analyst-54434
10/14/2019, 10:00 PMwitty-crayon-22786
10/14/2019, 10:00 PMenough-analyst-54434
10/14/2019, 10:00 PMwitty-crayon-22786
10/14/2019, 10:00 PMearly-needle-54791
10/14/2019, 10:00 PMwitty-crayon-22786
10/14/2019, 10:01 PMenough-analyst-54434
10/14/2019, 10:01 PMwitty-crayon-22786
10/14/2019, 10:01 PM$ git push -f pantsbuild rs-release
Counting objects: 5131, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (1738/1738), done.
Writing objects: 100% (5131/5131), 813.95 KiB | 0 bytes/s, done.
Total 5131 (delta 3939), reused 4445 (delta 3298)
remote: Resolving deltas: 100% (3939/3939), completed with 691 local objects.
To git@github.com:pantsbuild/grpc.git
+ 4158bd0...3b1b1a7 rs-release -> rs-release (forced update)
enough-analyst-54434
10/14/2019, 10:01 PMearly-needle-54791
10/14/2019, 10:03 PMenough-analyst-54434
10/14/2019, 10:04 PMearly-needle-54791
10/14/2019, 10:07 PMenough-analyst-54434
10/14/2019, 10:15 PMwitty-crayon-22786
10/14/2019, 10:16 PMearly-needle-54791
10/14/2019, 10:16 PMwitty-crayon-22786
10/14/2019, 10:17 PMenough-analyst-54434
10/14/2019, 10:17 PMaverage-vr-56795
10/14/2019, 10:18 PMDaniel got so close to switching to TowerI even switched! (I just gave up and switched back 😛)