@witty-crayon-22786 @average-vr-56795 Regarding https://github.com/pantsbuild/pants/pull/8371#discussion_r335520445 and https://github.com/pantsbuild/pants/pull/8371#discussion_r335487335 (moving the “materialize the dir for the nailgun server” code to

<http://nailgun_pool.rs|nailgun_pool.rs>

): I like the idea of making that work contained in that file, but something irks me about the idea of it having to know about

WorkunitStore

and

Store

. I guess it’s worth it for encapsulation, but having to pass those two things around I think dirties the API, I think.

That link didn’t take me to any particular code…

I guess… Yeah, you might be right. IT would be a much better case if we didn’t actually spawn the nailgun server in that file. But given that we do, it makes sense that everything should be there.

Indeed

But the

connect()

API was so clean… 😢

How clean is an API if it’s only clean because it’s a lie? 😉

Yeah, it was the rug under which the mound of …dust was hidden

yea, agreed with Daniel on this one. it's a hidden dependency otherwise.