https://pantsbuild.org/ logo
#development
Title
# development
r

red-balloon-89377

10/16/2019, 4:14 PM
@witty-crayon-22786 @average-vr-56795 Regarding https://github.com/pantsbuild/pants/pull/8371#discussion_r335520445 and https://github.com/pantsbuild/pants/pull/8371#discussion_r335487335 (moving the “materialize the dir for the nailgun server” code to
<http://nailgun_pool.rs|nailgun_pool.rs>
): I like the idea of making that work contained in that file, but something irks me about the idea of it having to know about
WorkunitStore
and
Store
. I guess it’s worth it for encapsulation, but having to pass those two things around I think dirties the API, I think.
a

average-vr-56795

10/16/2019, 4:20 PM
That link didn’t take me to any particular code…
If running a nailgun requires accessing the
Store
, I think that’s a dependency we should be happy to make explicit…
r

red-balloon-89377

10/16/2019, 4:21 PM
I guess… Yeah, you might be right. IT would be a much better case if we didn’t actually spawn the nailgun server in that file. But given that we do, it makes sense that everything should be there.
a

average-vr-56795

10/16/2019, 4:22 PM
Indeed
r

red-balloon-89377

10/16/2019, 4:22 PM
But the
connect()
API was so clean… 😢
Oh well
Thanks!
a

average-vr-56795

10/16/2019, 4:23 PM
How clean is an API if it’s only clean because it’s a lie? 😉
r

red-balloon-89377

10/16/2019, 4:23 PM
Yeah, it was the rug under which the mound of …dust was hidden
w

witty-crayon-22786

10/16/2019, 6:06 PM
yea, agreed with Daniel on this one. it's a hidden dependency otherwise.