`Session` is a cheap wrapper around an `Arc lt InnerSession Pants #development

`Session` is a cheap wrapper around an `Arc<Inn...

average-vr-56795

10/30/2019, 4:21 PM

Session

is a cheap wrapper around an

Arc<InnerSession>

which we clone and drop all over the place;

InnerSession

is the thing that has the correct lifetime

hundreds-breakfast-49010

10/30/2019, 10:38 PM

if I implement

Drop

InnerSession

, and just have the drop method print a line, I find that that line never gets printed

hundreds-breakfast-49010

10/30/2019, 10:38 PM

which I assume has something to do with interaction with the python FFI

hundreds-breakfast-49010

10/30/2019, 10:38 PM

I actually even added a panic and I forgot that I had left that in the code - it never gets called

average-vr-56795

10/31/2019, 9:04 AM

Interesting… Maybe we keep too many references to the Python

Session

object, or it’s referenced in a cycle somewhere, or something?

average-vr-56795

10/31/2019, 9:04 AM

Maybe we need to explicitly call

session_destroy

where we expect to be done with the

Session

on the Python side, rather than relying on

ffi.gc

to call it?

hundreds-breakfast-49010

10/31/2019, 5:16 PM

@average-vr-56795 when on the python side can we be sure we're done with a session?

hundreds-breakfast-49010

10/31/2019, 5:17 PM

also maybe it doesn't matter, and we can just start/stop a thread that polls the

Session

for the latest workunts purely in python

hundreds-breakfast-49010

10/31/2019, 5:17 PM

which is the approach I'm currently taking

average-vr-56795

10/31/2019, 5:35 PM

LocalPantsRunner._run

creates (via one of its method calls) the

Session

, and the

Session

can be cleaned up before that method returns