`Session` is a cheap wrapper around an `Arc lt InnerSession

Question

`Session` is a cheap wrapper around an `Arc lt InnerSession gt ` which we clone and drop all over the place `InnerSession` is the thing that has the correct lifetime

hundreds-breakfast-49010 · Answer

if I implement `Drop` on `InnerSession` and just have the drop method print a line I find that that line never gets printed

hundreds-breakfast-49010 · Answer

which I assume has something to do with interaction with the python FFI

hundreds-breakfast-49010 · Answer

I actually even added a panic and I forgot that I had left that in the code it never gets called

average-vr-56795 · Answer

Interesting Maybe we keep too many references to the Python `Session` object or it s referenced in a cycle somewhere or something

average-vr-56795 · Answer

Maybe we need to explicitly call `session destroy` where we expect to be done with the `Session` on the Python side rather than relying on `ffi gc` to call it

hundreds-breakfast-49010 · Answer

< average vr 56795> when on the python side can we be sure we re done with a session

hundreds-breakfast-49010 · Answer

also maybe it doesn t matter and we can just start stop a thread that polls the `Session` for the latest workunts purely in python

hundreds-breakfast-49010 · Answer

which is the approach I m currently taking

average-vr-56795 · Answer

`LocalPantsRunner run` creates via one of its method calls the `Session` and the `Session` can be cleaned up before that method returns