https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

11/11/2019, 4:58 PM
Yes this is part of the awkward transition period, but we’re fairly close to being able to have
partially_type_checked
work on all of
src
. Tracked by that ticket John linked to and this spreadsheet https://docs.google.com/spreadsheets/d/1MKg82Fs3uIMOZDoWeNUBD-VirVkOzHU8Tte7oY6ypP0/edit?usp=sharing I was prioritizing that last week and made a lot of progress. Hoping to work more on it this week. I’d love your help too! To port: 1) choose a target from that spreadsheet. We’re prioritizing high # dependees and low # dependencies 2) add the tag. See what breaks running mypy.py 3) fix any issues. If you had to fix issues in dependencies and they don’t yet have the tag, try adding it and seeing if it’s safe to do. 4) rinse and repeat until the PR is getting too big. I try to cap these typing ones at about 50 lines changed
a

aloof-angle-91616

11/11/2019, 11:12 PM
thank you so much! will choose a target and see how many times my head needs to bang against the wall
😂 1
h

hundreds-father-404

11/11/2019, 11:14 PM
feel free to DM me about anything! looks like I won’t have as much time this week as I was thinking for typing, but will have time for reviews and to help 🙂
a

aloof-angle-91616

11/11/2019, 11:14 PM
sounds like it'd be extra helpful for me to chip in then!
💯 1
h

hundreds-father-404

11/11/2019, 11:15 PM
Absolutely. We should try to get to all of
src
having
partially_type_checked
asap.
type_checked
for everything is much less important (especially since V1 code is eventually going to be replaced), but we do want MyPy at least running against everything