https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

11/11/2019, 9:45 PM
i.e. if I removed that and (eventually) replaced it with something making use of the python-side asynchronous workunit reporting I'm working on, would anyone complain?
w

witty-crayon-22786

11/11/2019, 9:49 PM
we are planning on relying on it, yes... should check in with @average-vr-56795, @salmon-summer-38098, @dry-policeman-7927
(all UK, so probably worth writing something up that they can review and answer in your tomorrow morning)
h

hundreds-breakfast-49010

11/11/2019, 10:52 PM
legit, I'll avoid changing anything aobut how that code path works then
w

witty-crayon-22786

11/11/2019, 11:12 PM
well, to be clear: it's ok to change things: just make sure you get some eyeballs on it before you do.
h

happy-kitchen-89482

11/12/2019, 2:36 AM
Yeah, best get @dry-policeman-7927's opinion, I think she did the heavy lifting on the zipkin stuff.
a

average-vr-56795

11/12/2019, 3:21 PM
Happy for the code to be reframed so that a zipkin uploader uses the async reporting as some kind of registerable sink or similar, but we definitely want to be able to upload to zipkin
h

happy-kitchen-89482

11/12/2019, 5:46 PM
Well, yes, I don't think the proposal was to remove the functionality... 🙂
w

witty-crayon-22786

11/12/2019, 5:59 PM
@happy-kitchen-89482: looking at the first comment in this thread, it sortof was, heh. but yea, agreement now