witty-crayon-22786
11/25/2019, 7:20 PMwitty-crayon-22786
11/25/2019, 7:23 PMwaiters
while it is running, when it fails it's pretty easy to send the failure to them directly, 2) but for requests after having failed, you cannot have "Complete"d the Node
, otherwise it won't run againwitty-crayon-22786
11/25/2019, 7:23 PMhundreds-breakfast-49010
11/25/2019, 7:24 PMwaiters
list meant to represent?witty-crayon-22786
11/25/2019, 7:24 PMNode
fails, it cannot "Complete": it must go back to NotStarted
witty-crayon-22786
11/25/2019, 7:25 PMget
, but for anyone trying to get
the Node later, you need to start running again, and the right way to do that is probably just to transition right to NotStarted
rather than Completingwitty-crayon-22786
11/25/2019, 7:25 PMwitty-crayon-22786
11/25/2019, 7:26 PMhundreds-breakfast-49010
11/25/2019, 7:29 PMhundreds-breakfast-49010
11/25/2019, 7:29 PMwitty-crayon-22786
11/25/2019, 7:29 PMCompleted
and EntryResult
from a Result<Item, Error>
to just Item
witty-crayon-22786
11/25/2019, 7:29 PMwitty-crayon-22786
11/25/2019, 7:29 PMwitty-crayon-22786
11/25/2019, 7:30 PMCompleted
to an Item
...?witty-crayon-22786
11/25/2019, 7:30 PMhundreds-breakfast-49010
11/25/2019, 7:30 PMNotStarted
case when a rule threw an exception, I would see that deliberate exception I put in the create_binary_rule
run about eight times, which seemed excessivehundreds-breakfast-49010
11/25/2019, 7:31 PMhundreds-breakfast-49010
11/25/2019, 7:31 PMwitty-crayon-22786
11/25/2019, 7:31 PMhundreds-breakfast-49010
11/25/2019, 7:31 PMNotComplete
witty-crayon-22786
11/25/2019, 7:32 PMhundreds-breakfast-49010
11/25/2019, 7:32 PMNotComplete
hundreds-breakfast-49010
11/25/2019, 7:32 PMwitty-crayon-22786
11/25/2019, 7:32 PMhundreds-breakfast-49010
11/25/2019, 7:33 PMhundreds-breakfast-49010
11/25/2019, 7:34 PM@rule
was completely deterministic, I think it would still be fine to change the type in the way you describewitty-crayon-22786
11/25/2019, 7:35 PMhundreds-breakfast-49010
11/25/2019, 7:35 PMwitty-crayon-22786
11/25/2019, 7:35 PMwitty-crayon-22786
11/25/2019, 7:36 PMhundreds-breakfast-49010
11/25/2019, 7:36 PMwitty-crayon-22786
11/25/2019, 7:37 PMwitty-crayon-22786
11/25/2019, 7:37 PMhundreds-breakfast-49010
11/25/2019, 7:39 PMwitty-crayon-22786
11/25/2019, 7:39 PMhundreds-breakfast-49010
11/25/2019, 7:40 PMhundreds-breakfast-49010
11/25/2019, 7:40 PMwitty-crayon-22786
11/25/2019, 7:40 PMhundreds-breakfast-49010
11/25/2019, 7:41 PMwitty-crayon-22786
11/25/2019, 7:43 PMwitty-crayon-22786
11/25/2019, 7:43 PMwitty-crayon-22786
11/25/2019, 7:44 PMhundreds-breakfast-49010
11/25/2019, 7:47 PMwitty-crayon-22786
11/25/2019, 7:47 PMwitty-crayon-22786
11/25/2019, 7:47 PMwitty-crayon-22786
11/25/2019, 7:48 PMhundreds-breakfast-49010
11/25/2019, 7:50 PMhundreds-breakfast-49010
11/25/2019, 7:51 PMhundreds-breakfast-49010
11/25/2019, 7:52 PM@rule
(although as you say we can make it harder to do the wrong thing)witty-crayon-22786
11/25/2019, 7:52 PMwitty-crayon-22786
11/25/2019, 7:53 PMhundreds-breakfast-49010
11/25/2019, 7:55 PMhundreds-breakfast-49010
11/25/2019, 7:56 PMhundreds-breakfast-49010
11/25/2019, 7:56 PMhundreds-breakfast-49010
11/25/2019, 7:56 PMhundreds-breakfast-49010
11/25/2019, 7:57 PMwitty-crayon-22786
11/25/2019, 7:58 PMhappy-kitchen-89482
11/25/2019, 8:12 PMwitty-crayon-22786
11/25/2019, 8:13 PMwitty-crayon-22786
11/25/2019, 8:14 PMhundreds-breakfast-49010
11/25/2019, 8:20 PMhundreds-breakfast-49010
11/25/2019, 8:20 PMwitty-crayon-22786
11/25/2019, 8:27 PMhundreds-breakfast-49010
11/25/2019, 8:30 PMhundreds-breakfast-49010
11/25/2019, 8:30 PMhundreds-breakfast-49010
11/25/2019, 8:31 PMProcessExecutionFailure
exceptionhundreds-breakfast-49010
11/25/2019, 8:33 PMhundreds-breakfast-49010
11/25/2019, 8:34 PMExecuteProcessResult
from a FallibleExecuteProcessResult
it might failhundreds-breakfast-49010
11/25/2019, 8:34 PMwitty-crayon-22786
11/25/2019, 8:36 PMhappy-kitchen-89482
11/26/2019, 5:17 PMwitty-crayon-22786
11/26/2019, 5:32 PMhundreds-breakfast-49010
11/27/2019, 12:57 AMhundreds-breakfast-49010
11/27/2019, 12:58 AMErr
values representing an exception-throwing @rule
, but if we had a rule we knew to be flaky (so, assuming that most of the time most `@rule`s are deterministic), we could add an argument marking the rule as suchhappy-kitchen-89482
11/27/2019, 1:57 AMhundreds-breakfast-49010
12/03/2019, 6:19 PMwitty-crayon-22786
12/03/2019, 6:57 PMwitty-crayon-22786
12/03/2019, 6:57 PMwitty-crayon-22786
12/03/2019, 6:59 PM