We currently want the following to work, I think:
...
# developmenta
average-vr-56795
11/28/2019, 5:40 PMWe currently want the following to work, I think:
./pants fmt test some:targettestw
witty-crayon-22786
12/03/2019, 3:35 AMI don't think that this is true. Writing files to the workspace will invalidate them.
witty-crayon-22786
12/03/2019, 3:49 AM...and if it doesn't, it could/should, eagerly.
a
average-vr-56795
12/03/2019, 10:43 AMI believe that if you happen to be using pantsd, this is true. And if you’re not, it isn’t.
average-vr-56795
12/03/2019, 10:43 AM(And if you are using pantsd, you rely on a race condition, but regardless, with invalidations set up, the result is probably doing the work twice, which is not great)
w
witty-crayon-22786
12/03/2019, 3:36 PMWell, that's the "eagerly" part. The call to materialize could invalidate eagerly. It's what we do in TestBase for files written via the
self.create_filea
average-vr-56795
12/03/2019, 3:38 PMStill feels kind of hacky to me 😞
w
witty-crayon-22786
12/03/2019, 5:12 PMWhen we sketched the design for this (ages ago: I think in one of your first visits to SF?) we came up with roughly this design. I think the fact that it relies on invalidation "between" goals is a bit odd, but I think the fact that we've isolated mutation to console_rule makes it fairly reasonable.
witty-crayon-22786
12/03/2019, 5:13 PMMutation anywhere else in the graph would definitely be sketchy, and I hope that we can continue to avoid that. cc @hundreds-breakfast-49010, @hundreds-father-404
👍 1