https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

12/13/2019, 7:52 PM
just noticed that right now, the --v2-ui flag breaks run (and probably any other goal that uses interactive process request): https://github.com/pantsbuild/pants/issues/8814
👍 1
I'm not sure what the best way to solve this is - maybe we should specifically detect if we are running an interactive process request and return the terminal to cooked mode?
that would break swimlanes, but we don't want to show swimlanes if the terminal is legitimately being used by the process we're running
@witty-crayon-22786 curious if you have any thoughts on this
I'm not sure if this is the only special case, where what pants legitimately wants to do with the terminal is going to conflict with showing swimlanes
h

happy-kitchen-89482

12/13/2019, 11:45 PM
Presumably we want to see the regular v2 ui right up until the actual run happens, but then we want to turn off the ui, so the user can interact with the running process
w

witty-crayon-22786

12/14/2019, 12:33 AM
similar to other `@console_rule`s, when the console_rule starts rendering things, we should assume that we are mostly finished with the heavy lifting
that might be an argument in favor of universally disabling the UI upon first output (rather than buffering it), and doing the same for an interactive process
...so yea, what Benjy said... plus the maybe-consideration of maybe-alignment with stdout/stderr rendering
blargh. i need to read to the end before responding. sorry.
h

hundreds-breakfast-49010

12/19/2019, 5:10 AM
w

witty-crayon-22786

12/19/2019, 8:30 AM
This is looking so effin good. Great work.