https://pantsbuild.org/ logo
Join Slack
Powered by
does anyone know what would happen if a `@rule` ra...
# development
h
does anyone know what would happen if a 
@rule
rather than a 
@console_rule
returned a 
Goal
subclass? would that be detected as a top-level goal?
a
i don’t think so (and can check) but is that behavior we think we might want?
h
no, I think it's behavior we don't want, but that might be possible
a
looking now
yes that is actually the behavior
it only checks if the rule is 
cacheable
to see whether it's an 
@console_rule
h
oh, cool, we're doing the right thing then
a
is cacheable true if and only if it’s a console rule?
h
I believe so
the only thing 
console_rule
does differently from 
rule
is set the cacheable flag to false when it creates a rule
and I don't think there's any other way we can make a rule
er, sorry, cacheable False if it's a console_rule, not true
a
yes, but i mean like would we want to consider e.g. adding an 
_is_console_rule
attribute on things decorated with 
@console_rule
?
would be good if i finally got this one in: https://github.com/pantsbuild/pants/pull/8496
w
"cacheable" has no other meaning right now... it's vestigial
a
thanks!
Open in Slack
PreviousNext
Powered by