https://pantsbuild.org/ logo
Powered by
w

witty-crayon-22786

01/09/2020, 6:55 PM
@hundreds-breakfast-49010: it's probably time to turn 
--v2-ui
on by default... thoughts?
h

hundreds-breakfast-49010

01/09/2020, 6:57 PM
I think there's probably a little bit of dogfooding left to do with it, but flipping on the switch all the time will incentivize that, so sure
👍 1
do we want to get rid of the --v2-ui flag altogether and make turning on the v2 UI something that comes with --v2, or just make the --v2-ui flag default yes?
w

witty-crayon-22786

01/09/2020, 6:59 PM
good question. we continue to not want it to render when we detect a tty, and i think that we do still want people to be able to disable it if they're scripting or something
so i think just toggling the default...?
h

hundreds-breakfast-49010

01/09/2020, 7:00 PM
that makes sense to me yeah
there's some logic in 
EngineDisplay
that tries to detect if its being run in a terminal or not, that I'm not sure if we actually want to keep
it might be cleaner to just always assume a terminal exists if v2_ui is True, and let users explicitly disable it via that flag if they don't want it
although then we might want to rename that flag to something else that doesn't have "v2" in it
➕ 1
👍 1
like --interactive_ui or something
h

hundreds-father-404

01/09/2020, 7:02 PM
Does the logging for tests still make sense? That was designed to make the test runner feel more interactive in a pre-v2-ui world and so that CI doesn’t stall (but CI now uses 
travis_wait
, so irrelelvant)
h

hundreds-breakfast-49010

01/09/2020, 7:03 PM
I'm not sure what you mean by logging for tests?
h

hundreds-father-404

01/09/2020, 7:03 PM
19:03:25 [INFO] Starting tests in debug mode: src/python/pants/option:tests
w

witty-crayon-22786

01/09/2020, 7:03 PM
the ui renders those.
case in point: more dogfooding 😉
h

hundreds-father-404

01/09/2020, 7:04 PM
the ui renders those.
Yes, I know. I’m wondering if it’s still relevant to keep
h

hundreds-breakfast-49010

01/09/2020, 7:04 PM
yeah I don't think that log message has anything to do with the v2 UI specifically
w

witty-crayon-22786

01/09/2020, 7:04 PM
ah. sorry.
h

hundreds-breakfast-49010

01/09/2020, 7:04 PM
the v2 UI will display anything logged; it sounds like you're questioning if we should continue having that log message there?
h

hundreds-father-404

01/09/2020, 7:04 PM
yes, exactly
w

witty-crayon-22786

01/09/2020, 7:05 PM
would recommend seeing how things feel with the UI on by default.
👍 1
if it no longer feels like it's carrying its weight, can prune logging
👍 1
h

hundreds-breakfast-49010

01/09/2020, 7:06 PM
I wouldn't be surprised if there are logging messages that no longer feel necessary when running with v2 UI
and we can get rid of those or change what level they log at on a case-by-case basis
💯 1
Powered by