https://pantsbuild.org/ logo
h

hundreds-father-404

01/10/2020, 8:54 PM
One pager for file system specs, particularly how rules will consume this. I bolded the two key arguments I’m making. Thoughts appreciated! https://docs.google.com/document/d/15xphZcFnowytF0Qu2sO1PG7wHAWoyLof7hK0jVa5T8E/edit#
w

witty-crayon-22786

01/10/2020, 9:55 PM
one big comment
(--owner-of ?)
h

hundreds-father-404

01/10/2020, 9:57 PM
Benjy and I were discussing. It boils down to this question: what should
./pants test src/python/pants/rule/core/fmt_test.py
do? Should it run every test in the target or only
fmt_test.py
? We both agree that it should get the owning target of
fmt_test.py
to calculate all the target info like dependencies, but it should only run tests on
fmt_test.py
, not
lint_test.py
etc.
w

witty-crayon-22786

01/10/2020, 10:00 PM
sure. the former thing is "owner-of". if the goal is then able to further filter based on the filename being used, that's a bonus
so, the top-level test goal would find a target, and then an individual test runner might interpret the spec to filter further
Which might imply neither of them requesting FileSpecs...?