I guess nothing is stopping us from deliberately p...
# development
I guess nothing is stopping us from deliberately publicly-sharing any google docs design document link that we feel is ok for public consumption, but that's a bit of friction and I don't think anyone's been consistently doing this - I certainly haven't been
I’m not sure I follow. I liberally link to the Google doc in my PRs
Public sharing is fine. I'd be in favor though of moving do markdown docs checked in to the repo. That would allow a normal PR to suffice as the design discussion plus have explicit sign-off. The biggest upside besides all that is you can actually reference real code well.
đź‘Ť 4
@hundreds-father-404 can random people who are coming across the pants project access them? and be guaranteed to access them on a long-term basis?
I always mark mine as “anyone with the link can comment”
I'm not sure what I do, I wasn't thinking about it until now
I think I generally give access to a doc to everyone on the pants-dev mailing list
Yeah, I just “anyone with the link can comment” that kind of thing
at Twitter, we have perennially had issues deciding early enough in a design process that something needs upstream involvement
and so it's very common for a doc to start closed (ie, using a google drive
account) and for us to realize afterward that it should be open
when we do, we have settled for
as the group to open for comments. we cannot completely open the doc for anonymous editors/viewers in that case.
convention is "not bad" though. it allows for a good balance of "relevant folks are able to read/comment" with spam protection