Hey I’m running into this when running

./pants

on a PR that changes

src/rust/engine/fs/src/lib.rs

. Greg ran into the issue early today. Any idea why this isn’t happening in CI?

error[E0432]: unresolved import `testutil`
 --> fs/src/posixfs_tests.rs:2:5
  |
2 | use testutil;
  |     ^^^^^^^^ no `testutil` external crate

error[E0433]: failed to resolve: use of undeclared type or module `tokio`
   --> fs/src/posixfs_tests.rs:374:21
    |
374 |   let mut runtime = tokio::runtime::Runtime::new().unwrap();
    |                     ^^^^^ use of undeclared type or module `tokio`

error: unused import: `tempfile`
 --> fs/src/posixfs_tests.rs:1:5
  |
1 | use tempfile;
  |     ^^^^^^^^
  |
note: lint level defined here
 --> fs/src/lib.rs:4:9
  |
4 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(unused_imports)]` implied by `#[deny(warnings)]`

error: unused imports: `GlobExpansionConjunction`, `GlobMatching`, `PathGlobs`, `PathStatGetter`, `PathStat`, `StrictGlobMatching`
 --> fs/src/posixfs_tests.rs:5:32
  |
5 |   Dir, DirectoryListing, File, GlobExpansionConjunction, GlobMatching, Link, PathGlobs, PathStat,
  |                                ^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^        ^^^^^^^^^  ^^^^^^^^
6 |   PathStatGetter, PosixFS, Stat, StrictGlobMatching, SymlinkBehavior, VFS,
  |   ^^^^^^^^^^^^^^                 ^^^^^^^^^^^^^^^^^^

error: unused import: `Future`
 --> fs/src/posixfs_tests.rs:9:31
  |
9 | use futures01::future::{self, Future};
  |                               ^^^^^^

hmmmm

i think i had cargo re-update from crates.io recently

how do you do that?

omg

Writing the PR description now!

great!

https://github.com/pantsbuild/pants/pull/9032 I’d greatly appreciate if you could please pull it down and try running

./pants

. Even if CI ends up going green, I’m concerned that when people pull master and run

./pants

, things will fail

running now

i repro

Hm this seems unlikely to pass CI, then

i'm gonna bisect script

I can’t figure out how to fix things. I tried removing the problematic imports but then it complained it couldn’t find the symbols

we apparently upgraded cargo to 1.40 as well

Ohhhh that sounds like it. I thought it was

async await

but that change was minimal and I don’t think that was it anymore

@hundreds-father-404:

#[cfg(test)]
mod fs_tests;
mod posixfs_tests;

has the effect of only the top thing being marked a test

ohhhhhhhh thank you!

yea, could definitely cause this.

[dependencies]

vs

[dev-dependencies]

TIL

yeaaa. that could be better.

That did it! Thank you! And thank you to @aloof-angle-91616 for diving in to this too

do we know why we had the different behavior locally vs CI?

do we know why we had the different behavior locally vs CI?

CI failed too. This was only happening on my branch because of the bad change I made Greg said he had encountered a very similar issue, though..not sure what that was

oh ok! thanks stu!