hundreds-father-404
01/29/2020, 5:00 AM./pants
on a PR that changes src/rust/engine/fs/src/lib.rs
. Greg ran into the issue early today. Any idea why this isn’t happening in CI?
error[E0432]: unresolved import `testutil`
--> fs/src/posixfs_tests.rs:2:5
|
2 | use testutil;
| ^^^^^^^^ no `testutil` external crate
error[E0433]: failed to resolve: use of undeclared type or module `tokio`
--> fs/src/posixfs_tests.rs:374:21
|
374 | let mut runtime = tokio::runtime::Runtime::new().unwrap();
| ^^^^^ use of undeclared type or module `tokio`
error: unused import: `tempfile`
--> fs/src/posixfs_tests.rs:1:5
|
1 | use tempfile;
| ^^^^^^^^
|
note: lint level defined here
--> fs/src/lib.rs:4:9
|
4 | #![deny(warnings)]
| ^^^^^^^^
= note: `#[deny(unused_imports)]` implied by `#[deny(warnings)]`
error: unused imports: `GlobExpansionConjunction`, `GlobMatching`, `PathGlobs`, `PathStatGetter`, `PathStat`, `StrictGlobMatching`
--> fs/src/posixfs_tests.rs:5:32
|
5 | Dir, DirectoryListing, File, GlobExpansionConjunction, GlobMatching, Link, PathGlobs, PathStat,
| ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^
6 | PathStatGetter, PosixFS, Stat, StrictGlobMatching, SymlinkBehavior, VFS,
| ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^
error: unused import: `Future`
--> fs/src/posixfs_tests.rs:9:31
|
9 | use futures01::future::{self, Future};
| ^^^^^^
aloof-angle-91616
01/29/2020, 5:02 AMhundreds-father-404
01/29/2020, 5:08 AMi think i had cargo re-update from crates.io recentlyhow do you do that?
aloof-angle-91616
01/29/2020, 5:23 AMhundreds-father-404
01/29/2020, 5:44 AMaloof-angle-91616
01/29/2020, 5:44 AMhundreds-father-404
01/29/2020, 5:49 AM./pants
. Even if CI ends up going green, I’m concerned that when people pull master and run ./pants
, things will failaloof-angle-91616
01/29/2020, 5:57 AMhundreds-father-404
01/29/2020, 5:57 AMi reproHm this seems unlikely to pass CI, then
aloof-angle-91616
01/29/2020, 5:57 AMhundreds-father-404
01/29/2020, 5:58 AMaloof-angle-91616
01/29/2020, 5:58 AMhundreds-father-404
01/29/2020, 5:59 AMasync await
but that change was minimal and I don’t think that was it anymorewitty-crayon-22786
01/29/2020, 6:01 AM#[cfg(test)]
mod fs_tests;
mod posixfs_tests;
has the effect of only the top thing being marked a testhundreds-father-404
01/29/2020, 6:02 AMwitty-crayon-22786
01/29/2020, 6:02 AM[dependencies]
vs [dev-dependencies]
hundreds-father-404
01/29/2020, 6:02 AMwitty-crayon-22786
01/29/2020, 6:03 AMhundreds-father-404
01/29/2020, 6:03 AMaloof-angle-91616
01/29/2020, 6:04 AMhundreds-father-404
01/29/2020, 6:04 AMdo we know why we had the different behavior locally vs CI?CI failed too. This was only happening on my branch because of the bad change I made Greg said he had encountered a very similar issue, though..not sure what that was
aloof-angle-91616
01/29/2020, 6:05 AM