We’re going to start requesting

ProvenancedBuildFileAddresses

in a couple goals like

fmt

,

lint

, and

test

(so that they can look at the filesystem specs and only run on the specified files, rather than the whole target)

ProvenancedBuildFileAddresses

is incredibly wordy. Any opposition to renaming to

ProvenancedAddresses

and

ProvenancedAddress

? This is the definition:

@dataclass(frozen=True)
class ProvenancedAddress:
  """A BuildFileAddress along with the cmd-line spec it was generated from."""
  build_file_address: BuildFileAddress
  provenance: Spec

I think this is a good idea

Cool, thanks. And should the field be

address: BuildFileAddress

or stay

build_file_address: BuildFileAddress

? Before MyPy, I’d always say the more verbose. Now, it just feels wordy and repetitive

yeah with the type anno I think it's fine to be less wordy

i personally have never understood the wording

Provenanced

and would suggest another name unless there's a reference i'm missing

It’s an old word for “origin”. I’ve been trying to think of a better name to express that. Maybe

AddressWithOrigin

? I don’t love having

with

in the name

OriginedAddress

seems off

Onboard with

AddressAndOrigin

-

Provenance

is a bit too much

@gentle-wolf-58752 proposed

AddressWithOriginSpec

. Thoughts? Imo, very clear. Possibly wordier than I’d like

^ i like the above reasoning!