https://pantsbuild.org/ logo
Powered by
w

witty-crayon-22786

02/07/2020, 12:47 AM
@careful-area-84205: would you mind reviewing https://github.com/pantsbuild/pants/pull/9080 ?
👍 1
c

careful-area-84205

02/07/2020, 12:48 AM
Ok, reviewing it now
@hundreds-father-404, I just approved it. But found this minor thing, just want to confirm with you if 
field_name="bundle(filespec=)",
should be 
field_name="bundle(fileset=)",
instead https://github.com/pantsbuild/pants/blob/52c513bafd574405933220289facdf3f6795d9c2/build-support/migration-support/fix_deprecated_globs_usage.py#L251
h

hundreds-father-404

02/07/2020, 1:16 AM
Good catch!
Powered by