is there a reason why `ProjectTree` and `FileSyste...
# development
h
is there a reason why
ProjectTree
and
FileSystemProjectTree
are two different classes?
­čĹŹ 1
it seems like
ProjectTree
is only inherited by
FileSystemProjectTree
also does anyone else find it confusing that this type seems to be Pr├│jectTree, as in a Tree that pertains to the noun "project"; but all the
project_
functions in
<http://externs.rs|externs.rs>
seem to be "proj├ęct_whatever", as in the verb "project"?
a
it seems like those uses are as far away as possible from each other in the codebase and i can't think of a better verb than
project
atm
h
the project thing I am just griping about ­čÖé
but I'm genuinely curious if there's a reason why we have that subclass split between
ProjectTree
and
FileSystemProjectTree
if there's not a good reason for it, I'd be tempted to combine them
the docstring says " Has two implementations: one backed by file system and one backed by SCM.". I'm not sure what SCM is here
and I can't find this other implementation. is this just an out-of-date comment?
a
hey i'm super sorry for not responding
i think you're right that it's out of date
"SCM" here probably refers to the
Scm
class
i saw your draft PR and it seems legit, not sure if it's out of draft yet
h
not sure which you mean, I've had a couple of PRs over the last few days that involved touching code there