https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

03/23/2020, 7:01 PM
so re: the cbindgen thing, I actually discovered that upgrading to the latest version breaks some tests, for reasons involving something about how to use cffi objects correctly changing: https://github.com/pantsbuild/pants/pull/9373
šŸ‘ 1
I don't wnat to spend too much more time on this since this is kind of tangential anyway, but basically if we upgrade cbindgen to 0.12.2, things are fine. when we upgrade to 0.13.0, the test in that commit msg as well as severla others brekas, and it has something to do with setting
throws
in
native.py
@average-vr-56795 you have any ideas here?
h

hundreds-father-404

03/23/2020, 7:07 PM
Probably punt on 1.13.0 and go with 1.12.2
a

average-vr-56795

03/23/2020, 11:46 PM
Yeah, Iā€™d punt. IIRC @aloof-angle-91616 added the cbindgen stuff originally?
a

aloof-angle-91616

03/23/2020, 11:53 PM
yeah sorry i should have stepped up to fix this
i would also punt since this week is hackweek for me, but would love to help address this after that!
h

hundreds-breakfast-49010

03/24/2020, 1:04 AM
@aloof-angle-91616 I don't think this is a big priority, I was only looking into this because of the test issue and because I happened to notice the crate version we use was like a year behind
a

aloof-angle-91616

03/24/2020, 1:04 AM
ah ok
thanks for looking into it!!
h

hundreds-breakfast-49010

03/24/2020, 1:05 AM
the linked comment is basically all the debugging I did, which amounts to figuring out that
response.throw
in native.py fails after the upgrade to version 0.13.0
šŸ‘ 1
a

aloof-angle-91616

03/24/2020, 1:06 AM
thank you for summarizing!