so re: the cbindgen thing, I actually discovered t...
# developmenth
hundreds-breakfast-49010
03/23/2020, 7:01 PMso re: the cbindgen thing, I actually discovered that upgrading to the latest version breaks some tests, for reasons involving something about how to use cffi objects correctly changing: https://github.com/pantsbuild/pants/pull/9373
š 1
hundreds-breakfast-49010
03/23/2020, 7:02 PMI don't wnat to spend too much more time on this since this is kind of tangential anyway, but basically if we upgrade cbindgen to 0.12.2, things are fine. when we upgrade to 0.13.0, the test in that commit msg as well as severla others brekas, and it has something to do with setting
throwsnative.pyhundreds-breakfast-49010
03/23/2020, 7:03 PM@average-vr-56795 you have any ideas here?
h
hundreds-father-404
03/23/2020, 7:07 PMProbably punt on 1.13.0 and go with 1.12.2
a
average-vr-56795
03/23/2020, 11:46 PMYeah, Iād punt. IIRC @aloof-angle-91616 added the cbindgen stuff originally?
a
aloof-angle-91616
03/23/2020, 11:53 PMyeah sorry i should have stepped up to fix this
aloof-angle-91616
03/23/2020, 11:58 PMi would also punt since this week is hackweek for me, but would love to help address this after that!
h
hundreds-breakfast-49010
03/24/2020, 1:04 AM@aloof-angle-91616 I don't think this is a big priority, I was only looking into this because of the test issue and because I happened to notice the crate version we use was like a year behind
a
aloof-angle-91616
03/24/2020, 1:04 AMah ok
aloof-angle-91616
03/24/2020, 1:04 AMthanks for looking into it!!
h
hundreds-breakfast-49010
03/24/2020, 1:05 AMthe linked comment is basically all the debugging I did, which amounts to figuring out that
response.throwš 1
a
aloof-angle-91616
03/24/2020, 1:06 AMthank you for summarizing!