aloof-angle-91616
04/06/2020, 12:01 AMtracing
crate (https://github.com/tokio-rs/tracing) to make it easier to define v2 workunit spans in rust? we could even spawn a zipkin span for every single method call if we wanted to, as well as every hop across the FFI boundary. the github page has a few examples describing why we might want to do this. the tracing
crate also decouples creating spans and logging those spans, where logging is delegated too a tracing::Subscriber
.
the two parts this needs are:
(1) to port to the tracing
crate, which i've started (a while ago) here: https://github.com/pantsbuild/pants/pull/7395
(2) to implement a tracing::Subscriber
for zipkin, which i've mostly done here: https://github.com/cosmicexplorer/learning-progress-bar/blob/master/zipkin/src/lib.rs, and can upstream in a separate PRwitty-crayon-22786
04/06/2020, 12:20 AMaloof-angle-91616
04/06/2020, 12:21 AMwitty-crayon-22786
04/06/2020, 12:25 AMaloof-angle-91616
04/06/2020, 12:25 AMwitty-crayon-22786
04/06/2020, 12:26 AMaloof-angle-91616
04/06/2020, 12:27 AMhundreds-breakfast-49010
04/06/2020, 4:47 PMtracing
to replace the current `WorkUnit`/`WorkUnitStore` abstraction and didn't get anywhere, so I decided it might be a better use of time to just continue using those abstractionstracing
crate when I was doing thatWorkUnit
abstraction), so I'd rather not spend time right now changing how that system workswitty-crayon-22786
04/11/2020, 4:53 PMaloof-angle-91616
04/11/2020, 4:54 PMwitty-crayon-22786
04/11/2020, 4:54 PMaloof-angle-91616
04/11/2020, 4:55 PMwitty-crayon-22786
04/11/2020, 9:07 PMtracing
. i think that this patch will be a good step in that direction, but the thread/task local management is too wheel-reinventy.hundreds-breakfast-49010
04/12/2020, 3:59 AM