https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

04/30/2020, 8:46 PM
I’m not sure how the hash will work with the Target API. Do those concepts still make sense for
intransitive_fingerprint_arg
and
transitive_fingerprint_arg
?
Hey @aloof-angle-91616, we’re trying to kill of
HydratedTarget
et al. Do you think it would be possible to get
TransitiveFingerprintedTarget
to work with the Target API instead? I’m not totally certain what that should look like, particularly with the fingerprints. Here are some Target API idioms for things you’re doing, though: *
tgt.get(Dependencies).value or ()
to get a
Tuple[Address, ...]
of dependencies *
await Get[TransitiveTargets](Addresses([tgt.address])
tgt.alias
for the type alias *
tgt.address
for the address
Also, would you be willing to split this up into two PRs? 1) Deprecate
--documented
and
--provides
for this new enum option. 2) Add JSON as a value of that enum option. It would make it much easier to review and to land
a

aloof-angle-91616

05/04/2020, 3:16 AM
i hadn't considered that at all, thanks!!
i can try to do that now
❤️ 1
h

hundreds-father-404

05/04/2020, 3:17 AM
Hadn’t considered which part? Using the Target API or splitting it up into two PRs?
a

aloof-angle-91616

05/04/2020, 3:18 AM
how natural the splitting would be and how i of course would want to also conform to the new target api in the implementation of the json output
❤️ 1
this will be my excuse to dive into the new target api
💯 1
👖 1
h

hundreds-father-404

05/04/2020, 3:19 AM
Awesome. I think splitting it up will make the second PR easier to reason with because now your diff is much smaller. Please let me know if I can help at all with the Target API! I’ll be around most of tonight taking this coursera linguistics course hehe