https://pantsbuild.org/ logo
#development
Title
# development
e

early-needle-54791

05/09/2020, 12:41 AM
Did the rust / cargo version get updated in the last few months? I cherry picked a pretty recent commit and I’m getting this error:
Copy code
error[E0658]: `&std::sync::Arc<InvalidationWatcher>` cannot be used as the type of `self` without the `arbitrary_self_types` feature
   --> watch/src/lib.rs:256:28
    |
256 |   pub async fn watch(self: &Arc<Self>, path: PathBuf) -> Result<(), notify::Error> {
    |                            ^^^^^^^^^^
    |
    = note: for more information, see <https://github.com/rust-lang/rust/issues/44874>
    = help: consider changing to `self`, `&self`, `&mut self`, `self: Box<Self>`, `self: Rc<Self>`, `self: Arc<Self>`, or `self: Pin<P>` (where P is one of the previous types except `Self`)
Its some kind of new experimental feature of rust, but I dont see a macro to enable it anywhere on master.
@witty-crayon-22786 this is from the move invalidation globs commit.
w

witty-crayon-22786

05/09/2020, 12:44 AM
it landed in stable in the fall… think you’re using an old rust somehow.
it’s definitely on
1.42
e

early-needle-54791

05/09/2020, 12:44 AM
okay I think I have 1.40 in my cache for some reason as well
I’ll get rid of it and see what happens
w

witty-crayon-22786

05/09/2020, 12:45 AM
different branches are pinned to different versions, but it should be present on anything that has async/await.
because it’s used in the implementation of async/await
e

early-needle-54791

05/09/2020, 12:46 AM
I see 1.42 in the cache, but Its not being selected by the build support cargo script correctly I guess
w

witty-crayon-22786

05/09/2020, 12:46 AM
which branch is this?
e

early-needle-54791

05/09/2020, 12:47 AM
I’m working off the 1.25.x-twtr branch doing cherry-picks
e

early-needle-54791

05/09/2020, 12:47 AM
I assumed the upgrade to tokio 0.2 pick I did would have had the necessary changes for rust but maybe they didn’t get carried over correctly
w

witty-crayon-22786

05/09/2020, 12:48 AM
(although i’m surprised that self types aren’t in 1.40)
e

early-needle-54791

05/09/2020, 12:48 AM
Thanks. I’ll bump that version
was looking in the wrong place for the version file anyway
w

witty-crayon-22786

05/09/2020, 12:49 AM
you might want to try to pick the bumps
e

early-needle-54791

05/09/2020, 12:50 AM
will do
I’ll try and hope its not a huge PR
heh no its a one liner