` pants ignore` doesn t seem as flexible as gitignore syntax

Question

` pants ignore` doesn t seem as flexible as gitignore syntax Is that known In the example Python repo these all fail to properly ignore ` pid` ` pants ignore= pids ` ` pants ignore= pids ` ` pants ignore= pids ` ` pants ignore= pids ` You have to use ` pants ignore= pids ` ` pants ignore= pids ` Running ` pants pants ignore= cloc `

hundreds-father-404 · Answer

cc < hundreds breakfast 49010>

hundreds-breakfast-49010 · Answer

hm didn t realize that

hundreds-breakfast-49010 · Answer

my recent changes with pants gitignore shouldn t have affected pants ignore but it s possible they broke something or that this bug was already in the code path

hundreds-father-404 · Answer

I confirmed that it makes no difference if this is defined in gitignore vs passed directly I ll update our docs to give the correct recommendation but people will think it s weird when we recommend ` pids ` instead of ` pids` so it would be great to fix

hundreds-breakfast-49010 · Answer

I wonder if that code path is incorrectly using the library that determines if a path matches a gitignore style path or if perhaps that library itself has a bug

hundreds-father-404 · Answer

Huh so I m testing now if the ` ` has something to do with this I tried to reproduce with this and can t ```$ mkdir demo echo print hello world n gt demo f py $ pants pants ignore= demo cloc demo f py $ pants pants ignore= demo cloc demo f py``` It always behaves correctly

hundreds-father-404 · Answer

Weird No matter what I do ` demo f py` is ignored

witty-crayon-22786 · Answer

` pids` is intentionally included

hundreds-father-404 · Answer

Hm Why I get this ```ERROR Failed to scan directory Users eric DocsLocal code projects example python pids watchman Expected File Dir or Link but pids watchman watchman sock relative to Users eric DocsLocal code projects example python was a FileType FileType mode 49152 ```

witty-crayon-22786 · Answer

as of <https github com pantsbuild pants pull 9636>

witty-crayon-22786 · Answer

oh hm

hundreds-father-404 · Answer

This is running ` pants cloc ` in the example repo

hundreds-father-404 · Answer

happens in master too

witty-crayon-22786 · Answer

it should only happen if you ve used watchman ie used pantsd before this release although that s not ideal

hundreds-father-404 · Answer

gt No matter what I do demo f py is ignored This is because of the default ignore of hidden files Okay

witty-crayon-22786 · Answer

i think there is a quick fix though can switch the hole we punch to be pantsd specific sorry about that

hundreds-father-404 · Answer

Cool Thanks < hundreds breakfast 49010> it looks like ` pants ignore` is in fact behaving properly Sorry for the false flag

hundreds-breakfast-49010 · Answer

so the ` pids` directory is special cased with < witty crayon 22786> s recent change before the gitignore processing code

witty-crayon-22786 · Answer

yep

witty-crayon-22786 · Answer

just testing the fix will post in a minute

witty-crayon-22786 · Answer

hm it looks like there might actually be a bad interaction with ignore i can t seem to make this more specific

witty-crayon-22786 · Answer

```works pids doesn t work pids pantsd ```

witty-crayon-22786 · Answer

i ll keep looking at it

witty-crayon-22786 · Answer

< hundreds father 404> for now can remove the watchman socket the latest release will not create it

witty-crayon-22786 · Answer

but i ll track this as a blocker

hundreds-father-404 · Answer

Thanks

witty-crayon-22786 · Answer

oh poop gt It is not possible to re include a file if a parent directory of that file is excluded <https git scm com docs gitignore>

hundreds-father-404 · Answer

and I don t think we want to create yet another directory to gitignore if posssible

hundreds-father-404 · Answer

Unless we remove ` pids` in favor of something new The issue would be having two folders at the same time

witty-crayon-22786 · Answer

so this is all in support of something that is lightly a hack

witty-crayon-22786 · Answer

i ll think about alternative methods

witty-crayon-22786 · Answer

< hundreds father 404> the workaround worked yea i ll probably look at this tomorrow morning

hundreds-father-404 · Answer

I just rm rfed pids and it worked fine

witty-crayon-22786 · Answer

k thanks i do want to fix this though i don t like the hack