https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

05/18/2020, 6:48 PM
@hundreds-father-404, @hundreds-breakfast-49010: https://github.com/pantsbuild/pants/pull/9797 might look hairy, but the key thing is just that errors with traces get much more compact, and render only the Nodes with `user_facing_name`s: would appreciate a look today when you get a chance
h

hundreds-father-404

05/18/2020, 6:48 PM
Would it help to have a review from both? I started taking a look and then thought “That’s a lot of Rust - maybe I’ll ask Greg to take a look”.. hehe
w

witty-crayon-22786

05/18/2020, 6:52 PM
the “is this trace useful for someone who would have
--print-exception-stacktrace
enabled” bit is a widely applicable bikeshed i think
but the model will make it easier to add/remove
Nodes
from traces, so also fine to just land it and defer the tuning of traces.
if you want to just eyeball the python test changes, and then let @hundreds-breakfast-49010 look at the rest, that’d be fine too.
💯 1
h

hundreds-breakfast-49010

05/18/2020, 6:55 PM
I'll take a look at this later today and focus on the rust parts