https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

05/21/2020, 12:05 AM
if you have two codegenerators, and you generated code with Protoc, you don’t want to also get the Thrift runtime dep
Agreed, but I’m not seeing why this would happen. What I’m proposing is that Protoc has an option
--runtime-targets
, which takes a list of arbitrary target addresses for runtime libraries. Whenever you have a
protobuf_library
, we will dynamically inject all of those
--protoc-runtime-targets
as direct dependencies for the
protobuf_library
. Then, a
python_library
which depends on the
protobuf_library
will get all of the Protoc runtime libraries (including the
JarLibrary
) when using
TransitiveTargets
. They won’t get anything to do with Thrift, unless the
python_library
depends on a
thrift_library