hundreds-father-404
06/01/2020, 8:38 PM▶ ./v2 --changed-since=HEAD fmt
20:30:55:734 [INFO] Completed: Run Black on 2 targets: src/python/pants/backend/python/dependency_inference, src/python/pants/backend/python/dependency_inference:tests.
20:30:55:736 [INFO] Completed: Format using Black
20:30:56:417 [INFO] Completed: Run Docformatter on 2 targets: src/python/pants/backend/python/dependency_inference, src/python/pants/backend/python/dependency_inference:tests.
20:30:56:418 [INFO] Completed: Format Python docstrings with docformatter
20:30:57:160 [INFO] Completed: Run isort on 2 targets: src/python/pants/backend/python/dependency_inference, src/python/pants/backend/python/dependency_inference:tests.
20:30:57:162 [INFO] Completed: Format using isort
𐄂 Black made changes.
reformatted src/python/pants/backend/python/dependency_inference/import_parser_test.py
All done! :sparkles: :cake: :sparkles:
1 file reformatted, 2 files left unchanged.
✓ Docformatter made no changes.
𐄂 isort made changes.
Fixing src/python/pants/backend/python/dependency_inference/import_parser.py
20:30:57:174 [INFO] Completed: `fmt` goal
I know that we can tune it, but I don’t think any of these log messages are particularly informative. The goal only took me 3 seconds to run, and now I have ~30 lines to read to make sense of the results.witty-crayon-22786
06/01/2020, 8:42 PM20:30:55:736 [INFO] Completed: Format using Black
20:30:56:418 [INFO] Completed: Format Python docstrings with docformatter
20:30:57:162 [INFO] Completed: Format using isort
20:30:57:174 [INFO] Completed: `fmt` goal
(…which we should do anyway because they don’t add anything over the processes underneath them)hundreds-father-404
06/01/2020, 8:45 PMso fixing that part would halve it.Agreed, but even fixing this, for this run that only takes 3 seconds, I don’t think any of the log messages are pulling their weight. And I suspect that’ll be the case for most local runs It would be neat if I could say
--verbose
to turn it on. Or if --no-dynamic-ui
turned it on, perhaps.witty-crayon-22786
06/01/2020, 8:45 PM▶ ./v2 --changed-since=HEAD fmt
20:30:55:734 [INFO] Completed: Run Black on 2 targets: src/python/pants/backend/python/dependency_inference, src/python/pants/backend/python/dependency_inference:tests.
20:30:56:417 [INFO] Completed: Run Docformatter on 2 targets: src/python/pants/backend/python/dependency_inference, src/python/pants/backend/python/dependency_inference:tests.
20:30:57:160 [INFO] Completed: Run isort on 2 targets: src/python/pants/backend/python/dependency_inference, src/python/pants/backend/python/dependency_inference:tests.
𐄂 Black made changes.
reformatted src/python/pants/backend/python/dependency_inference/import_parser_test.py
All done! :sparkles: :cake: :sparkles:
1 file reformatted, 2 files left unchanged.
✓ Docformatter made no changes.
𐄂 isort made changes.
Fixing src/python/pants/backend/python/dependency_inference/import_parser.py
hundreds-father-404
06/01/2020, 8:46 PMwitty-crayon-22786
06/01/2020, 8:46 PMhundreds-father-404
06/01/2020, 8:46 PMwitty-crayon-22786
06/01/2020, 8:46 PMhundreds-father-404
06/01/2020, 8:48 PMwitty-crayon-22786
06/01/2020, 8:48 PMAre we aiming to get that in by 1.30i can’t speak for @hundreds-breakfast-49010 or @happy-kitchen-89482, but if that’s “about three weeks”, then it seems reasonable to me
hundreds-breakfast-49010
06/01/2020, 8:49 PMhundreds-father-404
06/01/2020, 8:52 PMwitty-crayon-22786
06/01/2020, 8:53 PMlint
and test
(as discussed on the doc you had about this), i think that the completion and logs will be rendered in a streaming fashion by workunits, and one line per runner/target with pass/fail will be rendered by the console rulehundreds-father-404
06/01/2020, 8:54 PM[INFO]
?witty-crayon-22786
06/01/2020, 8:55 PM[ERROR]
, for examplehundreds-father-404
06/01/2020, 8:56 PMwitty-crayon-22786
06/01/2020, 8:56 PMhundreds-breakfast-49010
06/01/2020, 9:01 PMhundreds-father-404
06/01/2020, 9:02 PMhundreds-breakfast-49010
06/01/2020, 9:02 PMhundreds-father-404
06/01/2020, 9:02 PM<http://log.info|log.info>
that allows us to disable that prefix info? I think we still won’t be able to use the console to output, but if we could turn off the formatting in some situtations and keep it for others, problem solvedwitty-crayon-22786
06/01/2020, 9:03 PMhundreds-breakfast-49010
06/01/2020, 9:03 PMslog
rust crate so he could do structured logging in rustwitty-crayon-22786
06/01/2020, 9:04 PMfast-nail-55400
06/01/2020, 9:08 PMdocker build
, I like that output. If there are 14 steps, it will print all 14 and then run through them and colorize them as it executes them.witty-crayon-22786
06/01/2020, 9:17 PMhundreds-breakfast-49010
06/01/2020, 9:20 PMfast-nail-55400
06/01/2020, 9:25 PMvagrant@vagrant:/src/toolchain$ ./tc test src/python/toolchain/infosite::
21:24:51:970 [INFO] Starting tests: src/python/toolchain/infosite:tests
⠋ 14.03s Building requirements.pex with 24 requirements: Django==3.0.6, ansicolors==1.1.8, beautifulsoup4==4.
witty-crayon-22786
06/01/2020, 9:25 PMfast-nail-55400
06/01/2020, 9:26 PMwitty-crayon-22786
06/01/2020, 9:27 PMfast-nail-55400
06/01/2020, 9:27 PMwitty-crayon-22786
06/01/2020, 9:27 PM