https://pantsbuild.org/ logo
Join Slack
Powered by
<@UKPS08ZGW>, <@U0N6C2Q9F>: so the idea is to land...
# development
w
@hundreds-breakfast-49010, @fast-nail-55400: so the idea is to land https://github.com/pantsbuild/pants/pull/9897 before https://github.com/pantsbuild/pants/pull/9952 then? 9897 is green.
…well, it looks like they’re both probably green. 9952 had a network flake that i just restarted
h
I actually think that my changes in that PR (all test changes) won't actually interfere with @fast-nail-55400 's, I just put together that PR before I had fully looked at what he was doing
still, might as well merge his changes first
w
up to you both.
h
I'd say merge his first
I'm still not quite done and I'd rather be able to rebase and pull what tom has
w
sounds good.
@fast-nail-55400: if you’re ready, lemme know.
f
👍
w
do you mind cleaning up the description?
“accuratizing”
f
where do you see that?
h
I'm going to be afk for a few minutes while I run a quick errand. if my test PR goes green and doesn't conflict with tom's once that's merged, feel free to hit the button
w
@fast-nail-55400: sorry, i was making up a word. the description just has some stale stuff in it that you’ve since fixed.
and we use the description as the commit message.
f
sure, let me edit it now
what do I do with the “open questions” section though?
removing that removes useful context
GitHub should give you a chance to remove that from the commit message, correct?
w
yes. i don’t mind including open questions in a commit message. but if you’d rather i didn’t i can leave that out.
up to you.
f
ok edited
w
k, thanks
Open in Slack
PreviousNext
Powered by