https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

06/03/2020, 8:00 PM
@hundreds-breakfast-49010, @fast-nail-55400: so the idea is to land https://github.com/pantsbuild/pants/pull/9897 before https://github.com/pantsbuild/pants/pull/9952 then? 9897 is green.
…well, it looks like they’re both probably green. 9952 had a network flake that i just restarted
h

hundreds-breakfast-49010

06/03/2020, 8:02 PM
I actually think that my changes in that PR (all test changes) won't actually interfere with @fast-nail-55400 's, I just put together that PR before I had fully looked at what he was doing
still, might as well merge his changes first
w

witty-crayon-22786

06/03/2020, 8:02 PM
up to you both.
h

hundreds-breakfast-49010

06/03/2020, 8:02 PM
I'd say merge his first
I'm still not quite done and I'd rather be able to rebase and pull what tom has
w

witty-crayon-22786

06/03/2020, 8:03 PM
sounds good.
@fast-nail-55400: if you’re ready, lemme know.
f

fast-nail-55400

06/03/2020, 8:07 PM
👍
w

witty-crayon-22786

06/03/2020, 8:08 PM
do you mind cleaning up the description?
“accuratizing”
f

fast-nail-55400

06/03/2020, 8:08 PM
where do you see that?
h

hundreds-breakfast-49010

06/03/2020, 8:09 PM
I'm going to be afk for a few minutes while I run a quick errand. if my test PR goes green and doesn't conflict with tom's once that's merged, feel free to hit the button
w

witty-crayon-22786

06/03/2020, 8:09 PM
@fast-nail-55400: sorry, i was making up a word. the description just has some stale stuff in it that you’ve since fixed.
and we use the description as the commit message.
f

fast-nail-55400

06/03/2020, 8:09 PM
sure, let me edit it now
what do I do with the “open questions” section though?
removing that removes useful context
GitHub should give you a chance to remove that from the commit message, correct?
w

witty-crayon-22786

06/03/2020, 8:13 PM
yes. i don’t mind including open questions in a commit message. but if you’d rather i didn’t i can leave that out.
up to you.
f

fast-nail-55400

06/03/2020, 8:13 PM
ok edited
w

witty-crayon-22786

06/03/2020, 8:13 PM
k, thanks