hmm… i wonder how reliable <https://stackoverflow....
# developmentw
witty-crayon-22786
06/12/2020, 5:19 PMhmm… i wonder how reliable https://stackoverflow.com/questions/437589/how-do-i-unload-reload-a-module is …
h
hundreds-father-404
06/12/2020, 5:21 PMwhat’s the use case? I had major issues trying to get this to work on a personal project two years ago. I ended up splitting my script up into two parts and having the user rerun the script after part 1 finished
hundreds-father-404
06/12/2020, 5:21 PMI don’t remember the issue; just that it was hard and I realized not worth it
w
witty-crayon-22786
06/12/2020, 5:22 PMreloading rules without restarting pantsd
witty-crayon-22786
06/12/2020, 5:22 PMsortof a holy grail usecase, so would be great if there was a reliable way to do it.
h
hundreds-father-404
06/12/2020, 5:22 PMMy first instinct would be that this is not thread safe. Not sure if that’s true, but worth verifying
w
witty-crayon-22786
06/12/2020, 5:22 PMalthough i would not be surprised if there is not a reliable way, heh
witty-crayon-22786
06/12/2020, 5:23 PM@hundreds-father-404: oh yea, i’m sure it’s not. but we’d acquire a lock on the scheduler to reload.
👍 1
witty-crayon-22786
06/12/2020, 5:23 PMeven then, i think it still amounts to completely recreating the scheduler, but it means we don’t need to restart the server to pick up changes to the pythonpath.
witty-crayon-22786
06/12/2020, 5:24 PM(potential future work atop https://github.com/pantsbuild/pants/pull/10035)
witty-crayon-22786
06/14/2020, 3:39 PMLots of dragons : https://news.ycombinator.com/item?id=23498506
witty-crayon-22786
06/14/2020, 3:41 PMBut I think this relates to an idea @enough-analyst-54434 had had about "socket activation". On file change, we could cold reload in place in pantsd by re-exec'ing with our existing server socket. Wouldn't hold onto any state, but maybe that's for the best.
witty-crayon-22786
06/14/2020, 3:42 PMWorks for the "our pythonpath has changed" case, because we'd wait to do it until there were no active clients.
witty-crayon-22786
06/14/2020, 4:44 PM…but. reading more closely, most of the caveats are around static state, which we do not have for plugins. i think that we could probably actually do plugin auto-reload.