https://pantsbuild.org/ logo
#development
Title
# development
a

aloof-angle-91616

06/21/2020, 8:21 PM
also, now that twitter isn't consuming new releases of pants, do we have any performance regression testing for pants as a whole? if i was to unify glob matching in a later PR, i would want to make sure that i don't introduce any regressions to pants's filesystem traversal code. #9779 introduces criterion benchmarks for several snapshot operations -- is that kind of benchmarking sufficient to cover the use cases that e.g. pantsbench inside twitter did (if we continue to expand it)? cc @witty-crayon-22786 it's probably good that we're not having to worry about slowing down twitter's mostly-v1 use cases now, so it's not really a bad thing to be in the situation of not having existing perf testing to lean on, i think
h

hundreds-father-404

06/21/2020, 8:24 PM
we do not have performance monitoring, which is a big issue for the project. Tom has mentioned wanting to add at least a basic smoke screen to get started