https://pantsbuild.org/ logo
Join Slack
Powered by
<@UB2J9BQA0>: i think this came up in another cont...
# development
w
@hundreds-father-404: i think this came up in another context recently, but: the default behavior of 
dependencies --transitive ::
is very surprising
because 
transitive_targets.closure - FrozenOrderedSet(transitive_targets.roots)
… will be empty.
h
Agreed. And it’s not how v1 behaves
Should 
--transitive
include 
self
, or should we add something like we have with 
--dependees-closed
?
w
--closed
might make sense, especially if it is on by default
but even then, i think that that calculation might be incorrect. we should only be excluding a root from being included iff the only reason it would be included was because it was a root
h
Ah, that makes sense
w
so… i think the 
root
subtraction might be wrong there?
it’s possible that 
TransitiveTargets
should not be including the 
roots
in the 
closure
, and that there should be some other method that combines the two
h
it’s possible that TransitiveTargets  should not be including the roots in the closure
I’ve wanted this for a while. I was thinking we change the dataclass to be 
roots
and 
dependencies
, then have a memoized property 
closure
w
yea, something like that… naming pending checking the definition of “closure”
👍 1
Open in Slack
PreviousNext
Powered by