https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

06/23/2020, 9:38 PM
@hundreds-father-404: i think this came up in another context recently, but: the default behavior of
dependencies --transitive ::
is very surprising
because
transitive_targets.closure - FrozenOrderedSet(transitive_targets.roots)
… will be empty.
h

hundreds-father-404

06/23/2020, 9:38 PM
Agreed. And it’s not how v1 behaves
Should
--transitive
include
self
, or should we add something like we have with
--dependees-closed
?
w

witty-crayon-22786

06/23/2020, 9:40 PM
--closed
might make sense, especially if it is on by default
but even then, i think that that calculation might be incorrect. we should only be excluding a root from being included iff the only reason it would be included was because it was a root
h

hundreds-father-404

06/23/2020, 9:41 PM
Ah, that makes sense
w

witty-crayon-22786

06/23/2020, 9:41 PM
so… i think the
root
subtraction might be wrong there?
it’s possible that
TransitiveTargets
should not be including the
roots
in the
closure
, and that there should be some other method that combines the two
h

hundreds-father-404

06/23/2020, 9:43 PM
it’s possible that TransitiveTargets  should not be including the roots in the closure
I’ve wanted this for a while. I was thinking we change the dataclass to be
roots
and
dependencies
, then have a memoized property
closure
w

witty-crayon-22786

06/23/2020, 9:45 PM
yea, something like that… naming pending checking the definition of “closure”
👍 1