https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

06/25/2020, 10:26 PM
is any v2 code using the
engine_workunits
that we add in the reporting python code? https://github.com/pantsbuild/pants/blob/master/src/python/pants/bin/local_pants_runner.py#L263
w

witty-crayon-22786

06/25/2020, 10:39 PM
i don’t think so. the RunTracker uploads them if zipkin is configured…?
h

hundreds-breakfast-49010

06/25/2020, 10:42 PM
reason I ask is becuase if this code path isn't being used anymore, we could remove the
get_workunits
method from the workunit store
w

witty-crayon-22786

06/25/2020, 11:22 PM
yea. quite possibly. would check in on the pings that Eric and i have sent your way re: the RunTracker in PRs.
time to think about deleting portions of that