aloof-angle-91616
07/01/2020, 9:49 PMdef global_subsystems()
was v1-only? if i define a context-aware object factory in my v2 ruleset which pulls in a subsystem using .global_instance()
, i need that subsystem to be available. i was able to overcome this by just registering it as a v1 plugin as well, but unless we plan to literally deprecate .global_instance()
for v2 (which it's not clear that we are) it seems like we should allow global_subsystems
to be in v2 plugins as wellhundreds-father-404
07/01/2020, 9:54 PM.global_instance()
to simplify the Optionable code, but I don’t think anyone has any plans to do this yetaloof-angle-91616
07/01/2020, 9:56 PMhundreds-father-404
07/01/2020, 9:56 PMaloof-angle-91616
07/01/2020, 9:56 PMhundreds-father-404
07/01/2020, 9:56 PMobject
and CAFO
would access subsystemsaloof-angle-91616
07/01/2020, 9:57 PMSubsystemRule
or whatever it is now is just exactly what we needhundreds-father-404
07/01/2020, 9:57 PMi was trying to think of whether i had run into literally the only edge caseAgreed that I think object/CAFO are the only remaining uses of
.global_subsystem()
aloof-angle-91616
07/01/2020, 9:59 PMhundreds-father-404
07/01/2020, 10:00 PMpython_requirements
and pants_requirement
. And the new macros don’t work there because the loading mechanism; new macros are only internal to your own repo, afaictaloof-angle-91616
07/01/2020, 10:01 PMwitty-crayon-22786
07/01/2020, 10:01 PMaloof-angle-91616
07/01/2020, 10:01 PMwitty-crayon-22786
07/01/2020, 10:02 PMpython_requirements
is still the hold out.hundreds-father-404
07/01/2020, 10:03 PM