https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

07/02/2020, 4:01 PM
Hey there’s a lot of noise in CI now from things like
Starting: store_bytes
. Could we change those to DEBUG level?
cc @fast-nail-55400
w

witty-crayon-22786

07/02/2020, 4:04 PM
That relates to the overflow subtracting change as well I suspect. Cc @hundreds-breakfast-49010: should probably revert
f

fast-nail-55400

07/02/2020, 4:05 PM
yeah git blame says Greg’s change in 9651d48c17
👍 1
let metadata = workunit_store::WorkunitMetadata::new();
is initialized with INFO level
h

hundreds-father-404

07/02/2020, 4:06 PM
[WARN] No previously-started workunit found for id
also shows up. This likely should be DEBUG
h

hundreds-breakfast-49010

07/02/2020, 6:25 PM
I'm looking at this
👍 1
what do you mean by overflow subtracting change @witty-crayon-22786?
h

hundreds-father-404

07/02/2020, 6:34 PM
Thank you. It would be helpful to fix before the release today, if possible
h

hundreds-breakfast-49010

07/02/2020, 6:58 PM
@hundreds-father-404 do you know of a CI run that has the "No previously-started workunit found for id" error message? that should only happen if there's a legitimate bug with the workunit system itself
h

hundreds-father-404

07/02/2020, 7:03 PM
That warning only shows up for me locally. I haven’t seen it in CI. But I also haven’t been careful reading the logs because there’s so much output
h

hundreds-breakfast-49010

07/02/2020, 7:13 PM
do you have a command that reliably reproduces this locally?
h

hundreds-father-404

07/02/2020, 7:14 PM
No, I had run
./pants test src/python/pants/help/list_goals_integration_test.py
but that doesn’t reproduce
h

hundreds-breakfast-49010

07/02/2020, 7:17 PM
hm
I'm not sure if those should be at a warning level or not
if we ever see that no previously-started workunit error, that's a bug in pants that we need to fix
what's the right level for these sorts of errors?
h

hundreds-father-404

07/02/2020, 7:18 PM
If you keep it at a warning level, it would help to make actionable. Like,
This is a bug in Pants. If you’re willing, please post on [github link] the command that you ran, your
./pants --version
, and ..
h

hundreds-breakfast-49010

07/02/2020, 7:19 PM
makes sense
this strikes me as a broader issue - we should have some standard way of raising a warning that's specifically a pants issue, as opposed to an issue with the code being executed with pants
I'm not entirely sure why my change ended up creating more workunits with INFO level. https://github.com/pantsbuild/pants/pull/10238 explicitly changes some of them to DEBUG, I wanna see what this looks like in CI
h

hundreds-father-404

07/03/2020, 12:34 AM
Greg, I saw this at the end of the release script:
17:31:43.46 [WARN] No previously-started workunit found for id: 673dbb479310c00a
Not really something that can be reproduced though. Maybe put more than the workunit ID in the error message to help with debugging?