https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

07/17/2020, 4:57 PM
@hundreds-father-404: re cache dirs
there is at least one known issue in there, which is that
get_pants_cachedir
is not used for the LMDB store
which is in order to align with the default on the rust side. i started on a patch to move the implementation of that method to rust, but it runs into a bootstrapping issue because the rust bootstrap uses a hacky entrypoint into the BinaryUtils code to download things.
😶 1
h

hundreds-father-404

07/17/2020, 5:00 PM
That was the first thing I was going to fix 🙂
w

witty-crayon-22786

07/17/2020, 5:01 PM
i will likely be trying to untangle the hacky BinaryUtil thing for multiple reasons, but just fyi
one alternative would be to just have two “equivalent” implementations of the
get_pants_cachedir
method for now.
here’s the patch i had for it: https://github.com/pantsbuild/pants/compare/master...stuhood:stuhood/align-cache-roots … the commit message explains the cycle. but i think that the cycle could be broken by just having both python and rust implementations of the method
👍 1
@hundreds-father-404: i can clean that up and post if it helps.
the “duped method” approach isn’t actually that bad i think.
h

hundreds-father-404

07/17/2020, 5:06 PM
If it wouldn’t take too much time, that would be helpful to land it. I’m also not too concerned with a duplicated method, particularly if we call attention to it at both places.
w

witty-crayon-22786

07/17/2020, 5:07 PM
yea. ok.
❤️ 1
h

hundreds-father-404

07/17/2020, 5:07 PM
And we want to delete
BinaryUtil
as well, so that duplication is hopefully not permanent.
w

witty-crayon-22786

07/17/2020, 6:22 PM