<@UB2J9BQA0>: re cache dirs
# developmentw
witty-crayon-22786
07/17/2020, 4:57 PM@hundreds-father-404: re cache dirs
witty-crayon-22786
07/17/2020, 4:58 PMthere is at least one known issue in there, which is that
get_pants_cachedirwitty-crayon-22786
07/17/2020, 5:00 PMwhich is in order to align with the default on the rust side. i started on a patch to move the implementation of that method to rust, but it runs into a bootstrapping issue because the rust bootstrap uses a hacky entrypoint into the BinaryUtils code to download things.
š¶ 1
h
hundreds-father-404
07/17/2020, 5:00 PMThat was the first thing I was going to fix š
w
witty-crayon-22786
07/17/2020, 5:01 PMi will likely be trying to untangle the hacky BinaryUtil thing for multiple reasons, but just fyi
witty-crayon-22786
07/17/2020, 5:02 PMone alternative would be to just have two āequivalentā implementations of the
get_pants_cachedirwitty-crayon-22786
07/17/2020, 5:04 PMhereās the patch i had for it: https://github.com/pantsbuild/pants/compare/master...stuhood:stuhood/align-cache-roots ā¦ the commit message explains the cycle. but i think that the cycle could be broken by just having both python and rust implementations of the method
š 1
witty-crayon-22786
07/17/2020, 5:05 PM@hundreds-father-404: i can clean that up and post if it helps.
witty-crayon-22786
07/17/2020, 5:06 PMthe āduped methodā approach isnāt actually that bad i think.
h
hundreds-father-404
07/17/2020, 5:06 PMIf it wouldnāt take too much time, that would be helpful to land it. Iām also not too concerned with a duplicated method, particularly if we call attention to it at both places.
w
witty-crayon-22786
07/17/2020, 5:07 PMyea. ok.
ā¤ļø 1
h
hundreds-father-404
07/17/2020, 5:07 PMAnd we want to delete
BinaryUtilw
witty-crayon-22786
07/17/2020, 6:22 PM