https://pantsbuild.org/ logo
w

witty-crayon-22786

07/17/2020, 6:02 PM
um, i landed a performance regression with weak-Gets. following up on that.
👍 1
had everything nailed down performance wise, and then made a last minute change to an “obviously simpler” method which is apparently much slower! 🙃
h

hundreds-father-404

07/17/2020, 6:08 PM
Should I keep moving forward with the cycle tolerance? As in, the Python API is still the same right
I don’t think we need to revert with perf regressions, so long as it’s fixed before the next release
w

witty-crayon-22786

07/17/2020, 6:08 PM
yea, definitely. this is minor i think.
👍 1