https://pantsbuild.org/ logo
h

hundreds-breakfast-49010

08/18/2020, 5:14 AM
re: https://github.com/pantsbuild/pants/issues/10129, I am very sure that the multiple item-uncacheable Nodes are being invoked from the public
get()
function exposed by the
graph
crate
meaning I'm not sure that
graph
is actually doing anything wrong - if a caller of
get
invokes an uncacheable node, it shouldn't be cached. so if code external to that crate is invoking two near-identical versions fo the same Node corresponding to a Process invocation, we should get the behavior we're seeing
@witty-crayon-22786 do you have any thoughts?
w

witty-crayon-22786

08/18/2020, 9:26 PM
let’s talk about this as soon as https://github.com/pantsbuild/pants/pull/10645 lands. for now, would put it down and work on other things
👍 1