hundreds-breakfast-49010
08/19/2020, 8:01 PMFieldSet
subclasses that seem to be big, at least with the repro that asher was working withhundreds-father-404
08/19/2020, 8:14 PMFieldSet
is supposed to use @dataclass
. This means that each distinct subclass would need to override __str__
Taking a step back, with https://github.com/pantsbuild/pants/issues/10518, I don’t think any of the params should be included in that retry log, though? Imo we only want it to say “Retrying rule <name>“. The end user shouldn’t care what the params arealoof-angle-91616
08/19/2020, 8:14 PMhundreds-father-404
08/19/2020, 8:15 PM@goal_rule
that’s being run and display that. The end user doesn’t know what a rule is - it’s an implementation detail.
But if that’s difficult, then, only say “Retrying rule <name>” and nothing else