https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

08/19/2020, 8:01 PM
I should've been more precise, it's specifically
FieldSet
subclasses that seem to be big, at least with the repro that asher was working with
☝️ 1
h

hundreds-father-404

08/19/2020, 8:14 PM
Oh, that makes sense.
FieldSet
is supposed to use
@dataclass
. This means that each distinct subclass would need to override
__str__
Taking a step back, with https://github.com/pantsbuild/pants/issues/10518, I don’t think any of the params should be included in that retry log, though? Imo we only want it to say “Retrying rule <name>“. The end user shouldn’t care what the params are
👍 1
a

aloof-angle-91616

08/19/2020, 8:14 PM
+1
h

hundreds-father-404

08/19/2020, 8:15 PM
Even better would be to somehow find the
@goal_rule
that’s being run and display that. The end user doesn’t know what a rule is - it’s an implementation detail. But if that’s difficult, then, only say “Retrying rule <name>” and nothing else
☝️ 1