hundreds-father-404
09/02/2020, 10:53 PMpants-plugins/examples/bash/lint/shellcheck/rules_test.py:12: in <module>
from pants.core.goals.lint import LintResult, LintResults
E ModuleNotFoundError: No module named 'pants.core'
I can’t reproduce in Toolchain. And the plugin works when running via ./pants lint
. There are no import errors for the production codealoof-angle-91616
09/02/2020, 10:54 PMhundreds-father-404
09/02/2020, 10:55 PMaloof-angle-91616
09/02/2020, 10:56 PMhundreds-father-404
09/02/2020, 10:58 PM__init__.py
because Pytest handles those weirdly. But, we include those all in the dist. And what’s weird is that the same problematic import works for a Toolchain test, which also runs via the wheel pantsbuild.pants.testutil
rather than running from sourceshappy-kitchen-89482
09/02/2020, 11:27 PMpants
package.hundreds-father-404
09/02/2020, 11:28 PMnamespace_packages
in the wheel. It gets overridden to be empty accidentally__init__.py
in our example plugin repo. That’s probably the issue 😕
Gr, nope. Makes no differencepants.pantsbuild.testutil
and pantsbuild.pants
. If I remove testutil
, then the transitive imports of pants.core
are fine
Yeah. Toolchain “working” was a red herring. Toolchain fails too if I include an import from pants.pantsbuild.testutil
__init__.py
in Pants in 2.0.0.dev2. 1.30 and 2.0.0.dev1 works fine when running pex pantsbuild.pants pantsbuild.pants.testutil