https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

09/08/2020, 11:16 PM
is it just me or is the
daemonize()
method in
ProcessManager
not actuallydo anything? @witty-crayon-22786
w

witty-crayon-22786

09/08/2020, 11:17 PM
it does a double fork
h

hundreds-breakfast-49010

09/08/2020, 11:17 PM
right, but we're no longer double-forking pantsd, right? I don't see anything other than test code making calls to it
w

witty-crayon-22786

09/08/2020, 11:17 PM
but maybe i don’t understand the question
h

hundreds-breakfast-49010

09/08/2020, 11:18 PM
is there any reason not to delete that entire method from
ProcessManager
?
w

witty-crayon-22786

09/08/2020, 11:18 PM
ah. well, “not doing anything” and “not being called” are pretty different, heh
if it’s dead code, then can kill it, yea.
❤️ 1
h

hundreds-breakfast-49010

09/08/2020, 11:19 PM
it looks like dead code to me. i remember you or someone else saying that double-forking was the way pantsd used to work, but no longer is
👍 1
so okay, I'll remove that method and the test code that exercises it