<https://github.com/pantsbuild/pants/pull/10760> r...
# developmenth
hundreds-father-404
09/14/2020, 6:51 PMhttps://github.com/pantsbuild/pants/pull/10760 results in a hang when running
./pants testh
hundreds-breakfast-49010
09/14/2020, 6:55 PMI might try hooking up gdb using hte documentation tom wrote up: https://www.pantsbuild.org/v2.0/docs/contributions-debugging
đź‘Ť 1
w
witty-crayon-22786
09/14/2020, 7:15 PMmight also cherry-pick and enable https://github.com/pantsbuild/pants/pull/10734
witty-crayon-22786
09/14/2020, 7:17 PMare you able to repro it locally? would first want to see whether it is a deadlock or an infinite loop
h
hundreds-father-404
09/14/2020, 7:17 PMYes, I can repro it locally. And I didn’t encounter it yesterday before making some refactors, so I think we could isolate the couple lines of diff that cause it
w
witty-crayon-22786
09/14/2020, 7:18 PMa deadlock would have no CPU usage, whereas an (infinite) loop would have CPU usage
h
hundreds-father-404
09/14/2020, 7:19 PMFor that, would you look at something like
topw
witty-crayon-22786
09/14/2020, 7:19 PMyep.
h
hundreds-father-404
09/14/2020, 7:20 PMCool. (Aside, I recently downloaded a bunch of Rust rewrites of classic tools. https://zaiste.net/posts/shell-commands-rust/
batcatytopđź‘Ť 1
hundreds-father-404
09/15/2020, 6:49 AMInfinite loop, hehe:
Copy code
diff --git a/src/rust/engine/fs/store/src/snapshot_ops.rs b/src/rust/engine/fs/store/src/snapshot_ops.rs
index ad696ae55..092c470a3 100644
--- a/src/rust/engine/fs/store/src/snapshot_ops.rs
+++ b/src/rust/engine/fs/store/src/snapshot_ops.rs
@@ -665,7 +665,8 @@ pub trait SnapshotOps: StoreWrapper + 'static {
prefix: RelativePath,
) -> Result<Digest, SnapshotOpsError> {
let prefix: PathBuf = prefix.into();
- while let Some(parent) = prefix.iter().next_back() {
+ let mut prefix_iter = prefix.iter();
+ while let Some(parent) = prefix_iter.next_back() {
let mut dir_node = remexec::DirectoryNode::new();
dir_node.set_name(osstring_as_utf8(parent.to_os_string())?);
dir_node.set_digest((&digest).into());w
witty-crayon-22786
09/15/2020, 4:26 PMi’ve seen that exact issue at least three times. i did it once, benjy another time, and now you… heh
âť— 1
h
hundreds-father-404
09/15/2020, 4:30 PMSounds like something Clippy should check for!!
w
witty-crayon-22786
09/15/2020, 4:30 PMthe first two cases were in python
đź‘€ 1
h
hundreds-father-404
09/15/2020, 4:31 PMHuh, how did you do that in Python? Usually you don’t explicitly create the iterator
w
witty-crayon-22786
09/15/2020, 4:32 PM“while parent is not empty”
đź‘Ť 1