separately, just anything with skipped tests for a...
# developmenta
aloof-angle-91616
09/15/2020, 11:49 PMseparately, just anything with skipped tests for all the things it's supposed to cover feels radioactive to me and deserves more scrutiny. a tad annoyed that i tried to really solve this a long while ago and just let it deteriorate is all
❤️ 2
💯 2
h
hundreds-breakfast-49010
09/16/2020, 3:38 AMI think the main issue is that there's a lot of pants code (not just ExceptionSink) that was written before the engine existed and so tries to do things that the engine (or engine-adjacent python code) is also doing. we've also been moving functionality from python into the engine and plan to move more
✍️ 1
hundreds-breakfast-49010
09/16/2020, 3:38 AMso probably we should keep in mind as a general principle that when we make the engine do something that python code used to do, we should make sure we remove the old python code that did that at the same time
👌 1
hundreds-breakfast-49010
09/16/2020, 3:40 AMoff the top of my head, a lot of the tests that we're skipping are ones that pertain to pantsd, and one of the things that we should do is see if we can now unskip some of them, since there have been a lot of changes around pantsd and other parts of pants since we disabled those
⁉️ 1
a
aloof-angle-91616
09/16/2020, 5:10 AMwow, that's a great point
aloof-angle-91616
09/16/2020, 5:11 AMi'm not sure if i ever considered that
aloof-angle-91616
09/16/2020, 5:11 AMthat definitely seems like a stronger takeaway too
aloof-angle-91616
09/16/2020, 5:12 AMi have no issue with doing so and you can't monkey-patch things in rust which alone makes it a nicer place to do this, even if it's manipulating python objects with the cpython api
aloof-angle-91616
09/16/2020, 5:12 AMthanks!